Re: [PATCH] drm: add missing flags to DRM_MODE_FLAG_ALL

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 05:42:34PM +0200, Ville Syrjälä wrote: > On Wed, Dec 19, 2018 at 04:24:40PM +0100, Daniel Vetter wrote: > > On Wed, Dec 19, 2018 at 04:33:01PM +0200, Ville Syrjälä wrote: > > > On Wed, Dec 19, 2018 at 01:42:41PM +, emersion wrote: > > > > I guess DRM_MODE_FLAG_PIC_AR_MAS

Re: [PATCH] drm: add missing flags to DRM_MODE_FLAG_ALL

2018-12-19 Thread Ville Syrjälä
On Wed, Dec 19, 2018 at 04:24:40PM +0100, Daniel Vetter wrote: > On Wed, Dec 19, 2018 at 04:33:01PM +0200, Ville Syrjälä wrote: > > On Wed, Dec 19, 2018 at 01:42:41PM +, emersion wrote: > > > I guess DRM_MODE_FLAG_PIC_AR_MASK has been overlooked. > > > > Nope. We don't hang on to the aspect ra

Re: [PATCH] drm: add missing flags to DRM_MODE_FLAG_ALL

2018-12-19 Thread Daniel Vetter
On Wed, Dec 19, 2018 at 04:33:01PM +0200, Ville Syrjälä wrote: > On Wed, Dec 19, 2018 at 01:42:41PM +, emersion wrote: > > I guess DRM_MODE_FLAG_PIC_AR_MASK has been overlooked. > > Nope. We don't hang on to the aspect ratio flags internally > and they get wiped before we check against DRM_MOD

Re: [PATCH] drm: add missing flags to DRM_MODE_FLAG_ALL

2018-12-19 Thread Ville Syrjälä
On Wed, Dec 19, 2018 at 01:42:41PM +, emersion wrote: > I guess DRM_MODE_FLAG_PIC_AR_MASK has been overlooked. Nope. We don't hang on to the aspect ratio flags internally and they get wiped before we check against DRM_MODE_FLAG_ALL. Not sure this makes any sense really, but that's how it is at

[PATCH] drm: add missing flags to DRM_MODE_FLAG_ALL

2018-12-19 Thread emersion
I guess DRM_MODE_FLAG_PIC_AR_MASK has been overlooked. Signed-off-by: Simon Ser --- include/uapi/drm/drm_mode.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index d3e0fe31efc..b8d5226c8e5 100644 --- a/include/uapi