Re: [PATCH] drm: add check for plane functions

2017-03-21 Thread Harry Wentland
On 2017-03-20 05:42 AM, Shirish S wrote: On Mon, Mar 20, 2017 at 1:51 PM, Daniel Vetter wrote: On Mon, Mar 20, 2017 at 09:58:01AM +0530, Shirish S wrote: First of all, thanks for your comments/insights. On Sat, Mar 18, 2017 at 12:59 AM, Eric Anholt wrote: Ville Syrjälä writes: On Fri,

Re: [PATCH] drm: add check for plane functions

2017-03-20 Thread Shirish S
On Mon, Mar 20, 2017 at 1:51 PM, Daniel Vetter wrote: > On Mon, Mar 20, 2017 at 09:58:01AM +0530, Shirish S wrote: >> First of all, thanks for your comments/insights. >> >> On Sat, Mar 18, 2017 at 12:59 AM, Eric Anholt wrote: >> > Ville Syrjälä writes: >> > >> >> On Fri, Mar 17, 2017 at 05:57:52

Re: [PATCH] drm: add check for plane functions

2017-03-20 Thread Daniel Vetter
On Mon, Mar 20, 2017 at 09:58:01AM +0530, Shirish S wrote: > First of all, thanks for your comments/insights. > > On Sat, Mar 18, 2017 at 12:59 AM, Eric Anholt wrote: > > Ville Syrjälä writes: > > > >> On Fri, Mar 17, 2017 at 05:57:52PM +0100, Daniel Vetter wrote: > >>> On Fri, Mar 17, 2017 at 0

Re: [PATCH] drm: add check for plane functions

2017-03-19 Thread Shirish S
First of all, thanks for your comments/insights. On Sat, Mar 18, 2017 at 12:59 AM, Eric Anholt wrote: > Ville Syrjälä writes: > >> On Fri, Mar 17, 2017 at 05:57:52PM +0100, Daniel Vetter wrote: >>> On Fri, Mar 17, 2017 at 01:08:43PM +0200, Ville Syrjälä wrote: >>> > On Fri, Mar 17, 2017 at 03:46

Re: [PATCH] drm: add check for plane functions

2017-03-17 Thread Harry Wentland
On 2017-03-17 03:55 AM, Shirish S wrote: update_plane() and disable_plane() functions assoiciated with setting plane are called without any check, causing kernel panic. This patch adds the required check to avoid it. Change-Id: I0d6792608b33e674c217388aa57c4b7d680d9bc7 Signed-off-by: Shirish S

Re: [PATCH] drm: add check for plane functions

2017-03-17 Thread Eric Anholt
Ville Syrjälä writes: > On Fri, Mar 17, 2017 at 05:57:52PM +0100, Daniel Vetter wrote: >> On Fri, Mar 17, 2017 at 01:08:43PM +0200, Ville Syrjälä wrote: >> > On Fri, Mar 17, 2017 at 03:46:34PM +0530, Shirish S wrote: >> > > On Fri, Mar 17, 2017 at 3:26 PM, Ville Syrjälä >> > > wrote: >> > > > On

Re: [PATCH] drm: add check for plane functions

2017-03-17 Thread Ville Syrjälä
On Fri, Mar 17, 2017 at 05:57:52PM +0100, Daniel Vetter wrote: > On Fri, Mar 17, 2017 at 01:08:43PM +0200, Ville Syrjälä wrote: > > On Fri, Mar 17, 2017 at 03:46:34PM +0530, Shirish S wrote: > > > On Fri, Mar 17, 2017 at 3:26 PM, Ville Syrjälä > > > wrote: > > > > On Fri, Mar 17, 2017 at 01:25:08P

Re: [PATCH] drm: add check for plane functions

2017-03-17 Thread Daniel Vetter
On Fri, Mar 17, 2017 at 01:08:43PM +0200, Ville Syrjälä wrote: > On Fri, Mar 17, 2017 at 03:46:34PM +0530, Shirish S wrote: > > On Fri, Mar 17, 2017 at 3:26 PM, Ville Syrjälä > > wrote: > > > On Fri, Mar 17, 2017 at 01:25:08PM +0530, Shirish S wrote: > > >> update_plane() and disable_plane() funct

Re: [PATCH] drm: add check for plane functions

2017-03-17 Thread Ville Syrjälä
On Fri, Mar 17, 2017 at 03:46:34PM +0530, Shirish S wrote: > On Fri, Mar 17, 2017 at 3:26 PM, Ville Syrjälä > wrote: > > On Fri, Mar 17, 2017 at 01:25:08PM +0530, Shirish S wrote: > >> update_plane() and disable_plane() functions > >> assoiciated with setting plane are called > >> without any chec

Re: [PATCH] drm: add check for plane functions

2017-03-17 Thread Shirish S
On Fri, Mar 17, 2017 at 3:26 PM, Ville Syrjälä wrote: > On Fri, Mar 17, 2017 at 01:25:08PM +0530, Shirish S wrote: >> update_plane() and disable_plane() functions >> assoiciated with setting plane are called >> without any check, causing kernel panic. > > Why are you registering a plane without th

Re: [PATCH] drm: add check for plane functions

2017-03-17 Thread Ville Syrjälä
On Fri, Mar 17, 2017 at 01:25:08PM +0530, Shirish S wrote: > update_plane() and disable_plane() functions > assoiciated with setting plane are called > without any check, causing kernel panic. Why are you registering a plane without the funcs? > > This patch adds the required check to avoid it.

[PATCH] drm: add check for plane functions

2017-03-17 Thread Shirish S
update_plane() and disable_plane() functions assoiciated with setting plane are called without any check, causing kernel panic. This patch adds the required check to avoid it. Change-Id: I0d6792608b33e674c217388aa57c4b7d680d9bc7 Signed-off-by: Shirish S --- drivers/gpu/drm/drm_plane.c | 6 +