Re: [PATCH] drm: Use kvzalloc for allocating blob property memory

2018-07-02 Thread Daniel Vetter
On Fri, Jun 29, 2018 at 07:38:32PM +0300, Ville Syrjälä wrote: > On Fri, Jun 29, 2018 at 06:27:28PM +0200, Michel Dänzer wrote: > > On 2018-06-29 06:12 PM, Ville Syrjälä wrote: > > > On Fri, Jun 29, 2018 at 04:27:10PM +0200, Michel Dänzer wrote: > > >> From: Michel Dänzer > > >> > > >> The propert

Re: [PATCH] drm: Use kvzalloc for allocating blob property memory

2018-06-29 Thread Ville Syrjälä
On Fri, Jun 29, 2018 at 06:27:28PM +0200, Michel Dänzer wrote: > On 2018-06-29 06:12 PM, Ville Syrjälä wrote: > > On Fri, Jun 29, 2018 at 04:27:10PM +0200, Michel Dänzer wrote: > >> From: Michel Dänzer > >> > >> The property size may be controlled by userspace, can be large (I've > >> seen failure

Re: [PATCH] drm: Use kvzalloc for allocating blob property memory

2018-06-29 Thread Michel Dänzer
On 2018-06-29 06:12 PM, Ville Syrjälä wrote: > On Fri, Jun 29, 2018 at 04:27:10PM +0200, Michel Dänzer wrote: >> From: Michel Dänzer >> >> The property size may be controlled by userspace, can be large (I've >> seen failure with order 4, i.e. 16 pages / 64 KB) and doesn't need to be >> physically

Re: [PATCH] drm: Use kvzalloc for allocating blob property memory

2018-06-29 Thread Ville Syrjälä
On Fri, Jun 29, 2018 at 04:27:10PM +0200, Michel Dänzer wrote: > From: Michel Dänzer > > The property size may be controlled by userspace, can be large (I've > seen failure with order 4, i.e. 16 pages / 64 KB) and doesn't need to be > physically contiguous. I wonder if we should enforce some kin

Re: [PATCH] drm: Use kvzalloc for allocating blob property memory

2018-06-29 Thread Alex Deucher
On Fri, Jun 29, 2018 at 10:27 AM, Michel Dänzer wrote: > From: Michel Dänzer > > The property size may be controlled by userspace, can be large (I've > seen failure with order 4, i.e. 16 pages / 64 KB) and doesn't need to be > physically contiguous. > > Signed-off-by: Michel Dänzer Reviewed-by:

[PATCH] drm: Use kvzalloc for allocating blob property memory

2018-06-29 Thread Michel Dänzer
From: Michel Dänzer The property size may be controlled by userspace, can be large (I've seen failure with order 4, i.e. 16 pages / 64 KB) and doesn't need to be physically contiguous. Signed-off-by: Michel Dänzer --- drivers/gpu/drm/drm_property.c | 6 +++--- 1 file changed, 3 insertions(+),