Re: [PATCH] drm: Release filp before global lock

2020-01-22 Thread VMware
On 1/22/20 11:00 PM, Chris Wilson wrote: Quoting Thomas Hellström (VMware) (2020-01-22 21:52:23) Hi, Chris, On 1/22/20 4:56 PM, Chris Wilson wrote: The file is not part of the global drm resource and can be released prior to take the global mutex to drop the open_count (and potentially close)

Re: [PATCH] drm: Release filp before global lock

2020-01-22 Thread Chris Wilson
Quoting Thomas Hellström (VMware) (2020-01-22 21:52:23) > Hi, Chris, > > On 1/22/20 4:56 PM, Chris Wilson wrote: > > The file is not part of the global drm resource and can be released > > prior to take the global mutex to drop the open_count (and potentially > > close) the drm device. > > > > How

Re: [PATCH] drm: Release filp before global lock

2020-01-22 Thread VMware
Hi, Chris, On 1/22/20 4:56 PM, Chris Wilson wrote: The file is not part of the global drm resource and can be released prior to take the global mutex to drop the open_count (and potentially close) the drm device. However, inside drm_close_helper() there are a number of dev->driver callbacks tha

[PATCH] drm: Release filp before global lock

2020-01-22 Thread Chris Wilson
The file is not part of the global drm resource and can be released prior to take the global mutex to drop the open_count (and potentially close) the drm device. However, inside drm_close_helper() there are a number of dev->driver callbacks that take the drm_device as the first parameter... Worryi