Re: [PATCH] drm: Reject unknown legacy bpp and depth for drm_mode_addfb ioctl

2018-09-05 Thread Daniel Vetter
On Wed, Sep 05, 2018 at 11:22:05AM +0100, Chris Wilson wrote: > Since this is handling user provided bpp and depth, we need to sanity > check and propagate the EINVAL back rather than assume what the insane > client intended and fill the logs with DRM_ERROR. > > v2: Check both bpp and depth match

Re: [PATCH] drm: Reject unknown legacy bpp and depth for drm_mode_addfb ioctl

2018-09-05 Thread Chris Wilson
Quoting Chris Wilson (2018-09-05 11:22:05) > Since this is handling user provided bpp and depth, we need to sanity > check and propagate the EINVAL back rather than assume what the insane > client intended and fill the logs with DRM_ERROR. > > v2: Check both bpp and depth match the builtin pixel f

[PATCH] drm: Reject unknown legacy bpp and depth for drm_mode_addfb ioctl

2018-09-05 Thread Chris Wilson
Since this is handling user provided bpp and depth, we need to sanity check and propagate the EINVAL back rather than assume what the insane client intended and fill the logs with DRM_ERROR. v2: Check both bpp and depth match the builtin pixel format, and introduce a canonical DRM_FORMAT_INVALID t