Re: [PATCH] drm: Lock pointer access in drm_master_release()

2021-06-11 Thread Daniel Vetter
On Fri, Jun 11, 2021 at 4:18 AM Desmond Cheong Zhi Xi wrote: On 11/6/21 12:48 am, Daniel Vetter wrote: > > On Thu, Jun 10, 2021 at 11:21:39PM +0800, Desmond Cheong Zhi Xi wrote: > >> On 10/6/21 6:10 pm, Daniel Vetter wrote: > >>> On Wed, Jun 09, 2021 at 05:21:19PM +0800, Desmond Cheong Zhi Xi wro

Re: [PATCH] drm: Lock pointer access in drm_master_release()

2021-06-10 Thread Desmond Cheong Zhi Xi
On 11/6/21 1:49 am, Emil Velikov wrote: On Thu, 10 Jun 2021 at 11:10, Daniel Vetter wrote: On Wed, Jun 09, 2021 at 05:21:19PM +0800, Desmond Cheong Zhi Xi wrote: This patch eliminates the following smatch warning: drivers/gpu/drm/drm_auth.c:320 drm_master_release() warn: unlocked access 'mast

Re: [PATCH] drm: Lock pointer access in drm_master_release()

2021-06-10 Thread Desmond Cheong Zhi Xi
On 11/6/21 12:48 am, Daniel Vetter wrote: On Thu, Jun 10, 2021 at 11:21:39PM +0800, Desmond Cheong Zhi Xi wrote: On 10/6/21 6:10 pm, Daniel Vetter wrote: On Wed, Jun 09, 2021 at 05:21:19PM +0800, Desmond Cheong Zhi Xi wrote: This patch eliminates the following smatch warning: drivers/gpu/drm/d

Re: [PATCH] drm: Lock pointer access in drm_master_release()

2021-06-10 Thread Emil Velikov
On Thu, 10 Jun 2021 at 11:10, Daniel Vetter wrote: > > On Wed, Jun 09, 2021 at 05:21:19PM +0800, Desmond Cheong Zhi Xi wrote: > > This patch eliminates the following smatch warning: > > drivers/gpu/drm/drm_auth.c:320 drm_master_release() warn: unlocked access > > 'master' (line 318) expected lock

Re: [PATCH] drm: Lock pointer access in drm_master_release()

2021-06-10 Thread Daniel Vetter
On Thu, Jun 10, 2021 at 11:21:39PM +0800, Desmond Cheong Zhi Xi wrote: > On 10/6/21 6:10 pm, Daniel Vetter wrote: > > On Wed, Jun 09, 2021 at 05:21:19PM +0800, Desmond Cheong Zhi Xi wrote: > > > This patch eliminates the following smatch warning: > > > drivers/gpu/drm/drm_auth.c:320 drm_master_rele

Re: [PATCH] drm: Lock pointer access in drm_master_release()

2021-06-10 Thread Desmond Cheong Zhi Xi
On 10/6/21 6:10 pm, Daniel Vetter wrote: On Wed, Jun 09, 2021 at 05:21:19PM +0800, Desmond Cheong Zhi Xi wrote: This patch eliminates the following smatch warning: drivers/gpu/drm/drm_auth.c:320 drm_master_release() warn: unlocked access 'master' (line 318) expected lock '&dev->master_mutex' T

Re: [PATCH] drm: Lock pointer access in drm_master_release()

2021-06-10 Thread Daniel Vetter
On Wed, Jun 09, 2021 at 05:21:19PM +0800, Desmond Cheong Zhi Xi wrote: > This patch eliminates the following smatch warning: > drivers/gpu/drm/drm_auth.c:320 drm_master_release() warn: unlocked access > 'master' (line 318) expected lock '&dev->master_mutex' > > The 'file_priv->master' field shoul

[PATCH] drm: Lock pointer access in drm_master_release()

2021-06-09 Thread Desmond Cheong Zhi Xi
This patch eliminates the following smatch warning: drivers/gpu/drm/drm_auth.c:320 drm_master_release() warn: unlocked access 'master' (line 318) expected lock '&dev->master_mutex' The 'file_priv->master' field should be protected by the mutex lock to '&dev->master_mutex'. This is because other p