[PATCH] drm: Fix locking in drm_atomic_helper_resume

2017-05-31 Thread Daniel Vetter
In the conversion to drop drm_modeset_lock_all and the magic implicit context I failed to realize that _resume starts out with a pile of state copies, but not with the locks. And hence drm_atomic_commit won't grab these for us. v2: Add locking checks in helpers to make sure we catch this in the fu

Re: [PATCH] drm: Fix locking in drm_atomic_helper_resume

2017-05-30 Thread Maarten Lankhorst
Hey, Op 29-05-17 om 21:34 schreef Daniel Vetter: > In the conversion to drop drm_modeset_lock_all and the magic implicit > context I failed to realize that _resume starts out with a pile of > state copies, but not with the locks. And hence drm_atomic_commit > won't grab these for us. > > Cc: Jyri

[PATCH] drm: Fix locking in drm_atomic_helper_resume

2017-05-29 Thread Daniel Vetter
In the conversion to drop drm_modeset_lock_all and the magic implicit context I failed to realize that _resume starts out with a pile of state copies, but not with the locks. And hence drm_atomic_commit won't grab these for us. Cc: Jyri Sarha Fixes: a5b8444e289c ("drm/atomic-helper: remove modese