Re: [Intel-gfx] [PATCH] drm: Fix PANEL_ORIENTATION_QUIRKS breaking the Kconfig DRM menuconfig

2018-01-17 Thread Hans de Goede
Hi, On 17-01-18 09:48, Daniel Vetter wrote: On Wed, Jan 17, 2018 at 9:42 AM, Hans de Goede wrote: Hi, On 17-01-18 09:40, Daniel Vetter wrote: On Wed, Jan 17, 2018 at 09:10:32AM +0100, Hans de Goede wrote: All Kconfig menu menu entries should have a depends on MENU_OPTION, the menu stops a

Re: [Intel-gfx] [PATCH] drm: Fix PANEL_ORIENTATION_QUIRKS breaking the Kconfig DRM menuconfig

2018-01-17 Thread Hans de Goede
Hi, On 17-01-18 09:40, Daniel Vetter wrote: On Wed, Jan 17, 2018 at 09:10:32AM +0100, Hans de Goede wrote: All Kconfig menu menu entries should have a depends on MENU_OPTION, the menu stops after the first Kconfig entry without this depends on. Since the PANEL_ORIENTATION_QUIRKS option is also

[PATCH] drm: Fix PANEL_ORIENTATION_QUIRKS breaking the Kconfig DRM menuconfig

2018-01-17 Thread Hans de Goede
All Kconfig menu menu entries should have a depends on MENU_OPTION, the menu stops after the first Kconfig entry without this depends on. Since the PANEL_ORIENTATION_QUIRKS option is also used outside of DRM, it deliberately does not have a depends on DRM, but this causes all items after it to sho

Re: [Intel-gfx] [PATCH] drm: Fix PANEL_ORIENTATION_QUIRKS breaking the Kconfig DRM menuconfig

2018-01-17 Thread Daniel Vetter
On Wed, Jan 17, 2018 at 9:42 AM, Hans de Goede wrote: > Hi, > > On 17-01-18 09:40, Daniel Vetter wrote: >> >> On Wed, Jan 17, 2018 at 09:10:32AM +0100, Hans de Goede wrote: >>> >>> All Kconfig menu menu entries should have a depends on MENU_OPTION, the >>> menu stops after the first Kconfig entry

Re: [Intel-gfx] [PATCH] drm: Fix PANEL_ORIENTATION_QUIRKS breaking the Kconfig DRM menuconfig

2018-01-17 Thread Daniel Vetter
On Wed, Jan 17, 2018 at 09:10:32AM +0100, Hans de Goede wrote: > All Kconfig menu menu entries should have a depends on MENU_OPTION, the > menu stops after the first Kconfig entry without this depends on. > > Since the PANEL_ORIENTATION_QUIRKS option is also used outside of DRM, > it deliberately