Re: [PATCH] drm: Don't race connector registration

2017-02-01 Thread Dave Hansen
On 02/01/2017 12:52 AM, Daniel Vetter wrote: > On Tue, Jan 31, 2017 at 04:27:14PM -0800, Dave Hansen wrote: >> I added some printk()s all over and gathered a bit more information >> about what's going on. It looks like the display doesn't work until the >> drm connector code cleans up the *old* co

Re: [PATCH] drm: Don't race connector registration

2017-02-01 Thread Daniel Vetter
On Tue, Jan 31, 2017 at 04:27:14PM -0800, Dave Hansen wrote: > I added some printk()s all over and gathered a bit more information > about what's going on. It looks like the display doesn't work until the > drm connector code cleans up the *old* connector. For some reason, it > isn't motivated to

Re: [PATCH] drm: Don't race connector registration

2017-01-31 Thread Dave Hansen
I added some printk()s all over and gathered a bit more information about what's going on. It looks like the display doesn't work until the drm connector code cleans up the *old* connector. For some reason, it isn't motivated to do that until I go to the console and back. In this case, the displ

Re: [PATCH] drm: Don't race connector registration

2017-01-30 Thread Daniel Vetter
On Mon, Jan 30, 2017 at 08:43:17AM -0800, Dave Hansen wrote: > On 01/30/2017 01:12 AM, Daniel Vetter wrote: > > On Thu, Jan 26, 2017 at 12:34:29PM -0800, Dave Hansen wrote: > ... > >> And, yeah, I think it just gets the connected status wrong. The > >> connector is still there. > > > > Hm, I thou

Re: [PATCH] drm: Don't race connector registration

2017-01-30 Thread Dave Hansen
On 01/30/2017 01:12 AM, Daniel Vetter wrote: > On Thu, Jan 26, 2017 at 12:34:29PM -0800, Dave Hansen wrote: ... >> And, yeah, I think it just gets the connected status wrong. The >> connector is still there. > > Hm, I thought I replied here but I didn't: > - Is this just after boot (and then the

Re: [PATCH] drm: Don't race connector registration

2017-01-30 Thread Daniel Vetter
On Thu, Jan 26, 2017 at 12:34:29PM -0800, Dave Hansen wrote: > On 01/25/2017 07:38 AM, Daniel Vetter wrote: > > On Wed, Jan 25, 2017 at 07:20:45AM -0800, Dave Hansen wrote: > >> On 01/24/2017 10:21 PM, Daniel Vetter wrote: > >>> Hi Dave, > >>> > >>> Still waiting for your testing results on this on

Re: [PATCH] drm: Don't race connector registration

2017-01-26 Thread Dave Hansen
On 01/25/2017 07:38 AM, Daniel Vetter wrote: > On Wed, Jan 25, 2017 at 07:20:45AM -0800, Dave Hansen wrote: >> On 01/24/2017 10:21 PM, Daniel Vetter wrote: >>> Hi Dave, >>> >>> Still waiting for your testing results on this one here ... >> >> It's definitely stable with that patch applied. No more

Re: [PATCH] drm: Don't race connector registration

2017-01-25 Thread Dave Hansen
On 01/24/2017 10:21 PM, Daniel Vetter wrote: > Hi Dave, > > Still waiting for your testing results on this one here ... It's definitely stable with that patch applied. No more crashes. But, it's also definitely having difficulty re-probing to find the monitor that's attached to the dock in some

Re: [PATCH] drm: Don't race connector registration

2017-01-25 Thread Daniel Vetter
On Wed, Jan 25, 2017 at 07:20:45AM -0800, Dave Hansen wrote: > On 01/24/2017 10:21 PM, Daniel Vetter wrote: > > Hi Dave, > > > > Still waiting for your testing results on this one here ... > > It's definitely stable with that patch applied. No more crashes. > > But, it's also definitely having

Re: [PATCH] drm: Don't race connector registration

2017-01-24 Thread Daniel Vetter
Hi Dave, Still waiting for your testing results on this one here ... -Daniel On Thu, Jan 12, 2017 at 05:17:21PM +0100, Daniel Vetter wrote: > On Thu, Jan 12, 2017 at 05:15:56PM +0100, Daniel Vetter wrote: > > I was under the misconception that the sysfs dev stuff can be fully > > set up, and then

Re: [PATCH] drm: Don't race connector registration

2017-01-12 Thread Chris Wilson
On Thu, Jan 12, 2017 at 05:15:56PM +0100, Daniel Vetter wrote: > I was under the misconception that the sysfs dev stuff can be fully > set up, and then registered all in one step with device_add. That's > true for properties and property groups, but not for parents and child > devices. Those must b

Re: [PATCH] drm: Don't race connector registration

2017-01-12 Thread Daniel Vetter
On Thu, Jan 12, 2017 at 05:15:56PM +0100, Daniel Vetter wrote: > I was under the misconception that the sysfs dev stuff can be fully > set up, and then registered all in one step with device_add. That's > true for properties and property groups, but not for parents and child > devices. Those must b

[PATCH] drm: Don't race connector registration

2017-01-12 Thread Daniel Vetter
I was under the misconception that the sysfs dev stuff can be fully set up, and then registered all in one step with device_add. That's true for properties and property groups, but not for parents and child devices. Those must be fully registered before you can register a child. Add a bit of track