Re: [PATCH] drm: Don't free jobs in wait_event_interruptible()

2019-09-26 Thread Grodzovsky, Andrey
On 9/26/19 3:07 AM, Koenig, Christian wrote: > Am 25.09.19 um 17:14 schrieb Steven Price: >> drm_sched_cleanup_jobs() attempts to free finished jobs, however because >> it is called as the condition of wait_event_interruptible() it must not >> sleep. Unfortunately some free callbacks (notably for

Re: [PATCH] drm: Don't free jobs in wait_event_interruptible()

2019-09-26 Thread Grodzovsky, Andrey
On 9/26/19 5:41 AM, Steven Price wrote: > On 25/09/2019 21:09, Grodzovsky, Andrey wrote: >> On 9/25/19 12:07 PM, Andrey Grodzovsky wrote: >>> On 9/25/19 12:00 PM, Steven Price wrote: >>> On 25/09/2019 16:56, Grodzovsky, Andrey wrote: > On 9/25/19 11:14 AM, Steven Price wrote: > >>

Re: [PATCH] drm: Don't free jobs in wait_event_interruptible()

2019-09-26 Thread Koenig, Christian
Am 26.09.19 um 11:47 schrieb Steven Price: > On 26/09/2019 08:07, Koenig, Christian wrote: >> Am 25.09.19 um 17:14 schrieb Steven Price: >>> drm_sched_cleanup_jobs() attempts to free finished jobs, however because >>> it is called as the condition of wait_event_interruptible() it must not >>> sleep

Re: [PATCH] drm: Don't free jobs in wait_event_interruptible()

2019-09-26 Thread Steven Price
On 26/09/2019 08:07, Koenig, Christian wrote: > Am 25.09.19 um 17:14 schrieb Steven Price: >> drm_sched_cleanup_jobs() attempts to free finished jobs, however because >> it is called as the condition of wait_event_interruptible() it must not >> sleep. Unfortunately some free callbacks (notably for

Re: [PATCH] drm: Don't free jobs in wait_event_interruptible()

2019-09-26 Thread Steven Price
On 25/09/2019 21:09, Grodzovsky, Andrey wrote: > > On 9/25/19 12:07 PM, Andrey Grodzovsky wrote: >> On 9/25/19 12:00 PM, Steven Price wrote: >> >>> On 25/09/2019 16:56, Grodzovsky, Andrey wrote: On 9/25/19 11:14 AM, Steven Price wrote: > drm_sched_cleanup_jobs() attempts to free fini

Re: [PATCH] drm: Don't free jobs in wait_event_interruptible()

2019-09-26 Thread Koenig, Christian
Am 25.09.19 um 17:14 schrieb Steven Price: > drm_sched_cleanup_jobs() attempts to free finished jobs, however because > it is called as the condition of wait_event_interruptible() it must not > sleep. Unfortunately some free callbacks (notably for Panfrost) do sleep. > > Instead let's rename drm_sc

Re: [PATCH] drm: Don't free jobs in wait_event_interruptible()

2019-09-25 Thread Grodzovsky, Andrey
On 9/25/19 12:07 PM, Andrey Grodzovsky wrote: > On 9/25/19 12:00 PM, Steven Price wrote: > >> On 25/09/2019 16:56, Grodzovsky, Andrey wrote: >>> On 9/25/19 11:14 AM, Steven Price wrote: >>> drm_sched_cleanup_jobs() attempts to free finished jobs, however because it is called as the

Re: [PATCH] drm: Don't free jobs in wait_event_interruptible()

2019-09-25 Thread Grodzovsky, Andrey
On 9/25/19 12:00 PM, Steven Price wrote: > On 25/09/2019 16:56, Grodzovsky, Andrey wrote: >> On 9/25/19 11:14 AM, Steven Price wrote: >> >>> drm_sched_cleanup_jobs() attempts to free finished jobs, however because >>> it is called as the condition of wait_event_interruptible() it must not >>> slee

Re: [PATCH] drm: Don't free jobs in wait_event_interruptible()

2019-09-25 Thread Steven Price
On 25/09/2019 16:56, Grodzovsky, Andrey wrote: > On 9/25/19 11:14 AM, Steven Price wrote: > >> drm_sched_cleanup_jobs() attempts to free finished jobs, however because >> it is called as the condition of wait_event_interruptible() it must not >> sleep. Unfortunately some free callbacks (notably fo

Re: [PATCH] drm: Don't free jobs in wait_event_interruptible()

2019-09-25 Thread Grodzovsky, Andrey
On 9/25/19 11:14 AM, Steven Price wrote: > drm_sched_cleanup_jobs() attempts to free finished jobs, however because > it is called as the condition of wait_event_interruptible() it must not > sleep. Unfortunately some free callbacks (notably for Panfrost) do sleep. > > Instead let's rename drm_sch

[PATCH] drm: Don't free jobs in wait_event_interruptible()

2019-09-25 Thread Steven Price
drm_sched_cleanup_jobs() attempts to free finished jobs, however because it is called as the condition of wait_event_interruptible() it must not sleep. Unfortunately some free callbacks (notably for Panfrost) do sleep. Instead let's rename drm_sched_cleanup_jobs() to drm_sched_get_cleanup_job() an