Re: [Intel-gfx] [PATCH] drm: Don't complain too much about struct_mutex.

2017-07-18 Thread Daniel Vetter
On Sat, Jul 15, 2017 at 12:02:47PM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2017-07-15 10:53:28) > > For modern drivers the DRM core doesn't use struct_mutex at all, which > > means it's defacto a driver-private lock. But since we still need it > > for legacy drivers we can't initialize

Re: [PATCH] drm: Don't complain too much about struct_mutex.

2017-07-17 Thread Peter Zijlstra
On Mon, Jul 17, 2017 at 05:06:42PM +0200, Daniel Vetter wrote: > On Mon, Jul 17, 2017 at 11:35 AM, Peter Zijlstra wrote: > > On Sat, Jul 15, 2017 at 11:53:28AM +0200, Daniel Vetter wrote: > >> A more complete solution would be to do the mutex_init in the drm core > >> only for legacy drivers, plus

Re: [PATCH] drm: Don't complain too much about struct_mutex.

2017-07-17 Thread Daniel Vetter
On Mon, Jul 17, 2017 at 11:35 AM, Peter Zijlstra wrote: > On Sat, Jul 15, 2017 at 11:53:28AM +0200, Daniel Vetter wrote: >> A more complete solution would be to do the mutex_init in the drm core >> only for legacy drivers, plus add it to each modern driver that still >> needs it, which would also

Re: [PATCH] drm: Don't complain too much about struct_mutex.

2017-07-17 Thread Peter Zijlstra
On Sat, Jul 15, 2017 at 11:53:28AM +0200, Daniel Vetter wrote: > A more complete solution would be to do the mutex_init in the drm core > only for legacy drivers, plus add it to each modern driver that still > needs it, which would also give each its own lockdep key. Trying to do > that dynamically

Re: [Intel-gfx] [PATCH] drm: Don't complain too much about struct_mutex.

2017-07-15 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-15 10:53:28) > For modern drivers the DRM core doesn't use struct_mutex at all, which > means it's defacto a driver-private lock. But since we still need it > for legacy drivers we can't initialize it in drivers, which means all > the different instances share one loc

Re: [Intel-gfx] [PATCH] drm: Don't complain too much about struct_mutex.

2017-07-15 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-15 10:53:28) > For modern drivers the DRM core doesn't use struct_mutex at all, which > means it's defacto a driver-private lock. But since we still need it > for legacy drivers we can't initialize it in drivers, which means all > the different instances share one loc

[PATCH] drm: Don't complain too much about struct_mutex.

2017-07-15 Thread Daniel Vetter
For modern drivers the DRM core doesn't use struct_mutex at all, which means it's defacto a driver-private lock. But since we still need it for legacy drivers we can't initialize it in drivers, which means all the different instances share one lockdep key. Despite that they might be placed in total