[PATCH] drm: Document caveats around atomic event handling

2016-09-30 Thread Daniel Vetter
It's not that obvious how a driver can all race the atomic commit with handling the completion event. And there's unfortunately a pile of drivers with rather bad event handling which misdirect people into the wrong direction. Try to remedy this by documenting everything better. v2: Type fixes Ale

[PATCH] drm: Document caveats around atomic event handling

2016-09-30 Thread Daniel Stone
On 30 September 2016 at 11:55, Daniel Stone wrote: > Hi, > > [...] ... and with that, Reviewed-by: Daniel Stone Cheers, Daniel, off to find more coffee

[PATCH] drm: Document caveats around atomic event handling

2016-09-30 Thread Daniel Stone
Hi, On 29 September 2016 at 16:20, Daniel Vetter wrote: > + * 1. Driver commits new hardware state into vblank-synchronized registes. > + * 2. A vblank happes, committing the hardware state. Also the corresponding > + *vblank interrupt is fired off and fully processed by the interrupt > + *

[PATCH] drm: Document caveats around atomic event handling

2016-09-30 Thread Daniel Vetter
On Fri, Sep 30, 2016 at 9:56 AM, Andrzej Hajda wrote: > Hi Daniel, > > Thanks for very descriptive comment. > Few comments/questions below. > > On 29.09.2016 17:50, Daniel Vetter wrote: >> It's not that obvious how a driver can all race the atomic commit with >> handling the completion event. And

[PATCH] drm: Document caveats around atomic event handling

2016-09-30 Thread Andrzej Hajda
Hi Daniel, Thanks for very descriptive comment. Few comments/questions below. On 29.09.2016 17:50, Daniel Vetter wrote: > It's not that obvious how a driver can all race the atomic commit with > handling the completion event. And there's unfortunately a pile of > drivers with rather bad event han

[PATCH] drm: Document caveats around atomic event handling

2016-09-29 Thread Daniel Vetter
It's not that obvious how a driver can all race the atomic commit with handling the completion event. And there's unfortunately a pile of drivers with rather bad event handling which misdirect people into the wrong direction. Try to remedy this by documenting everything better. v2: Type fixes Ale

[PATCH] drm: Document caveats around atomic event handling

2016-09-29 Thread Daniel Vetter
It's not that obvious how a driver can all race the atomic commit with handling the completion event. And there's unfortunately a pile of drivers with rather bad event handling which misdirect people into the wrong direction. Try to remedy this by documenting everything better. Cc: Andrzej Hajda

[PATCH] drm: Document caveats around atomic event handling

2016-09-29 Thread Alex Deucher
On Thu, Sep 29, 2016 at 11:50 AM, Daniel Vetter wrote: > It's not that obvious how a driver can all race the atomic commit with > handling the completion event. And there's unfortunately a pile of > drivers with rather bad event handling which misdirect people into the > wrong direction. > > Try

[PATCH] drm: Document caveats around atomic event handling

2016-09-29 Thread Alex Deucher
On Thu, Sep 29, 2016 at 11:20 AM, Daniel Vetter wrote: > It's not that obvious how a driver can all race the atomic commit with > handling the completion event. And there's unfortunately a pile of > drivers with rather bad event handling which misdirect people into the > wrong direction. Thanks