Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-07 Thread Daniel Vetter
On Thu, Jan 7, 2021 at 7:16 PM Mario Kleiner wrote: > > On Thu, Jan 7, 2021 at 7:04 PM Daniel Vetter wrote: >> >> On Thu, Jan 7, 2021 at 7:00 PM Mario Kleiner >> wrote: >> > >> > On Thu, Jan 7, 2021 at 6:57 PM Daniel Vetter wrote: >> >> >> >> On Sat, Jan 02, 2021 at 04:31:36PM +0100, Mario Kle

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-07 Thread Mario Kleiner
On Thu, Jan 7, 2021 at 7:04 PM Daniel Vetter wrote: > On Thu, Jan 7, 2021 at 7:00 PM Mario Kleiner > wrote: > > > > On Thu, Jan 7, 2021 at 6:57 PM Daniel Vetter wrote: > >> > >> On Sat, Jan 02, 2021 at 04:31:36PM +0100, Mario Kleiner wrote: > >> > On Sat, Jan 2, 2021 at 3:02 PM Bas Nieuwenhuize

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-07 Thread Daniel Vetter
On Thu, Jan 7, 2021 at 7:00 PM Mario Kleiner wrote: > > On Thu, Jan 7, 2021 at 6:57 PM Daniel Vetter wrote: >> >> On Sat, Jan 02, 2021 at 04:31:36PM +0100, Mario Kleiner wrote: >> > On Sat, Jan 2, 2021 at 3:02 PM Bas Nieuwenhuizen >> > wrote: >> > > >> > > With modifiers one can actually have di

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-07 Thread Mario Kleiner
On Thu, Jan 7, 2021 at 6:57 PM Daniel Vetter wrote: > On Sat, Jan 02, 2021 at 04:31:36PM +0100, Mario Kleiner wrote: > > On Sat, Jan 2, 2021 at 3:02 PM Bas Nieuwenhuizen > > wrote: > > > > > > With modifiers one can actually have different format_info structs > > > for the same format, which now

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-07 Thread Mario Kleiner
> > Cc: dri-devel ; amd-gfx list > g...@lists.freedesktop.org>; Deucher, Alexander > > ; Daniel Vetter ; > > Kazlauskas, Nicholas ; Ville Syrjälä > > > > Subject: RE: [PATCH] drm: Check actual format for legacy pageflip. > > > > > > > -Origin

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-07 Thread Daniel Vetter
On Sat, Jan 02, 2021 at 04:31:36PM +0100, Mario Kleiner wrote: > On Sat, Jan 2, 2021 at 3:02 PM Bas Nieuwenhuizen > wrote: > > > > With modifiers one can actually have different format_info structs > > for the same format, which now matters for AMDGPU since we convert > > implicit modifiers to exp

RE: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-07 Thread Liu, Zhan
der > ; Daniel Vetter ; > Kazlauskas, Nicholas ; Ville Syrjälä > > Subject: RE: [PATCH] drm: Check actual format for legacy pageflip. > > > > -Original Message- > > From: Liu, Zhan > > Sent: 2021/January/04, Monday 3:46 PM > > To: Bas Nieuwenhu

RE: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-06 Thread Liu, Zhan
el Vetter ; > Kazlauskas, Nicholas ; Ville Syrjälä > > Subject: Re: [PATCH] drm: Check actual format for legacy pageflip. > > > > + Ville > > On Sat, Jan 2, 2021 at 4:31 PM Mario Kleiner > wrote: > > > > On Sat, Jan 2, 2021 at 3:02 PM Bas Nieuwenhuizen >

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-04 Thread Liu, Zhan
[AMD Official Use Only - Internal Distribution Only] + Ville On Sat, Jan 2, 2021 at 4:31 PM Mario Kleiner wrote: > > On Sat, Jan 2, 2021 at 3:02 PM Bas Nieuwenhuizen > wrote: > > > > With modifiers one can actually have different format_info structs > > for the same format, which now matters fo

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-04 Thread Bas Nieuwenhuizen
+ Ville On Sat, Jan 2, 2021 at 4:31 PM Mario Kleiner wrote: > > On Sat, Jan 2, 2021 at 3:02 PM Bas Nieuwenhuizen > wrote: > > > > With modifiers one can actually have different format_info structs > > for the same format, which now matters for AMDGPU since we convert > > implicit modifiers to ex

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-04 Thread Alex Deucher
On Sat, Jan 2, 2021 at 9:02 AM Bas Nieuwenhuizen wrote: > > With modifiers one can actually have different format_info structs > for the same format, which now matters for AMDGPU since we convert > implicit modifiers to explicit modifiers with multiple planes. > > I checked other drivers and it do

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-04 Thread Christian König
Am 02.01.21 um 15:02 schrieb Bas Nieuwenhuizen: With modifiers one can actually have different format_info structs for the same format, which now matters for AMDGPU since we convert implicit modifiers to explicit modifiers with multiple planes. I checked other drivers and it doesn't look like th

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-04 Thread Pierre-Eric Pelloux-Prayer
Hi Bas, On 02/01/2021 15:02, Bas Nieuwenhuizen wrote: > With modifiers one can actually have different format_info structs > for the same format, which now matters for AMDGPU since we convert > implicit modifiers to explicit modifiers with multiple planes. > > I checked other drivers and it doesn

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-02 Thread Mario Kleiner
On Sat, Jan 2, 2021 at 3:02 PM Bas Nieuwenhuizen wrote: > > With modifiers one can actually have different format_info structs > for the same format, which now matters for AMDGPU since we convert > implicit modifiers to explicit modifiers with multiple planes. > > I checked other drivers and it do

[PATCH] drm: Check actual format for legacy pageflip.

2021-01-02 Thread Bas Nieuwenhuizen
With modifiers one can actually have different format_info structs for the same format, which now matters for AMDGPU since we convert implicit modifiers to explicit modifiers with multiple planes. I checked other drivers and it doesn't look like they end up triggering this case so I think this is