[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2011-01-10 Thread Andrew Lutomirski
On Mon, Dec 27, 2010 at 7:58 AM, Mario Kleiner wrote: > On Dec 26, 2010, at 3:53 PM, Andrew Lutomirski wrote: > >> On Wed, Dec 22, 2010 at 4:06 PM, Mario Kleiner >> wrote: >>> >>> There's a new drm module parameter for selecting the timeout: echo 50 > >>> /sys/module/drm/parameters/vblankoffdelay

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2011-01-09 Thread Andrew Lutomirski
On Mon, Dec 27, 2010 at 7:58 AM, Mario Kleiner wrote: > On Dec 26, 2010, at 3:53 PM, Andrew Lutomirski wrote: > >> On Wed, Dec 22, 2010 at 4:06 PM, Mario Kleiner >> wrote: >>> >>> There's a new drm module parameter for selecting the timeout: echo 50 > >>> /sys/module/drm/parameters/vblankoffdelay

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-27 Thread Mario Kleiner
On Dec 27, 2010, at 12:16 PM, Ville Syrj?l? wrote: > On Mon, Dec 27, 2010 at 12:58:10AM +0100, Mario Kleiner wrote: > >> 2. There are gpu's firing spurious vblank irq's as soon as you enable >> irq's > > You're sure this isn't simply a matter of the driver forgetting to ack > the irq just before

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-27 Thread Mario Kleiner
On Dec 27, 2010, at 12:16 PM, Ville Syrjälä wrote: On Mon, Dec 27, 2010 at 12:58:10AM +0100, Mario Kleiner wrote: 2. There are gpu's firing spurious vblank irq's as soon as you enable irq's You're sure this isn't simply a matter of the driver forgetting to ack the irq just before enabling i

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-27 Thread Ville Syrjälä
On Mon, Dec 27, 2010 at 12:58:10AM +0100, Mario Kleiner wrote: > 2. There are gpu's firing spurious vblank irq's as soon as you enable > irq's You're sure this isn't simply a matter of the driver forgetting to ack the irq just before enabling it? -- Ville Syrj?l? syrjala at sci.fi http://www.

[PATCH] drm: Aggressively disable vblanks

2010-12-27 Thread Michel Dänzer
On Son, 2010-12-26 at 09:53 -0500, Andrew Lutomirski wrote: > On Wed, Dec 22, 2010 at 4:06 PM, Mario Kleiner > wrote: > > > > There's a new drm module parameter for selecting the timeout: echo 50 > > > /sys/module/drm/parameters/vblankoffdelay > > would set the timeout to 50 msecs. A setting of z

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-27 Thread Ville Syrjälä
On Mon, Dec 27, 2010 at 12:58:10AM +0100, Mario Kleiner wrote: > 2. There are gpu's firing spurious vblank irq's as soon as you enable > irq's You're sure this isn't simply a matter of the driver forgetting to ack the irq just before enabling it? -- Ville Syrjälä syrj...@sci.fi http://www.sc

Re: [PATCH] drm: Aggressively disable vblanks

2010-12-27 Thread Michel Dänzer
On Son, 2010-12-26 at 09:53 -0500, Andrew Lutomirski wrote: > On Wed, Dec 22, 2010 at 4:06 PM, Mario Kleiner > wrote: > > > > There's a new drm module parameter for selecting the timeout: echo 50 > > > /sys/module/drm/parameters/vblankoffdelay > > would set the timeout to 50 msecs. A setting of z

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-27 Thread Mario Kleiner
On Dec 26, 2010, at 3:53 PM, Andrew Lutomirski wrote: > On Wed, Dec 22, 2010 at 4:06 PM, Mario Kleiner > wrote: >> >> There's a new drm module parameter for selecting the timeout: echo >> 50 > >> /sys/module/drm/parameters/vblankoffdelay >> would set the timeout to 50 msecs. A setting of zero w

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-26 Thread Mario Kleiner
On Dec 26, 2010, at 3:53 PM, Andrew Lutomirski wrote: On Wed, Dec 22, 2010 at 4:06 PM, Mario Kleiner wrote: There's a new drm module parameter for selecting the timeout: echo 50 > /sys/module/drm/parameters/vblankoffdelay would set the timeout to 50 msecs. A setting of zero will disable

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-26 Thread Andrew Lutomirski
On Wed, Dec 22, 2010 at 4:06 PM, Mario Kleiner wrote: > > There's a new drm module parameter for selecting the timeout: echo 50 > > /sys/module/drm/parameters/vblankoffdelay > would set the timeout to 50 msecs. A setting of zero will disable the timer, > so vblank irq's would stay on all the time.

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-26 Thread Andrew Lutomirski
On Wed, Dec 22, 2010 at 4:06 PM, Mario Kleiner wrote: > > There's a new drm module parameter for selecting the timeout: echo 50 > > /sys/module/drm/parameters/vblankoffdelay > would set the timeout to 50 msecs. A setting of zero will disable the timer, > so vblank irq's would stay on all the time.

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-22 Thread Mario Kleiner
9:23:40 -0800 >>> From: Keith Packard >>> Subject: Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks >>> To: Andy Lutomirski , Jesse Barnes >>> , Chris Wilson >> wilson.co.uk>, >>> David Airlie >>> Cc: intel-gfx at lists

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-22 Thread Mario Kleiner
n, 20 Dec 2010 22:34:12 -0500 From: Andrew Lutomirski Subject: Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks To: Keith Packard Cc: intel-...@lists.freedesktop.org, dri-devel@lists.freedesktop.org Message-ID: Content-Type: text/plain; charset=ISO-8859-1 On Mon, Dec 20, 2010 at 10:23

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-22 Thread Jesse Barnes
On Wed, 22 Dec 2010 05:36:13 +0100 Mario Kleiner wrote: > > -- > > > > Message: 1 > > Date: Mon, 20 Dec 2010 19:23:40 -0800 > > From: Keith Packard > > Subject: Re: [Intel-gfx] [PATCH] drm:

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-22 Thread Jesse Barnes
On Wed, 22 Dec 2010 05:36:13 +0100 Mario Kleiner wrote: > > -- > > > > Message: 1 > > Date: Mon, 20 Dec 2010 19:23:40 -0800 > > From: Keith Packard > > Subject: Re: [Intel-gfx] [PATCH] drm:

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-22 Thread Mario Kleiner
> -- > > Message: 1 > Date: Mon, 20 Dec 2010 19:23:40 -0800 > From: Keith Packard > Subject: Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks > To: Andy Lutomirski , Jesse Barnes >

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-21 Thread Mario Kleiner
-- Message: 1 Date: Mon, 20 Dec 2010 19:23:40 -0800 From: Keith Packard Subject: Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks To: Andy Lutomirski , Jesse Barnes , Chris Wilson , David Airlie

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Andrew Lutomirski
On Mon, Dec 20, 2010 at 10:47 PM, Keith Packard wrote: > On Mon, 20 Dec 2010 22:34:12 -0500, Andrew Lutomirski wrote: > >> But five seconds is a *long* time, and anything short enough that the >> interrupt actually gets turned off in normal use risks the same race. > > Right, so eliminating any r

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Andrew Lutomirski
On Mon, Dec 20, 2010 at 10:23 PM, Keith Packard wrote: > On Mon, 20 Dec 2010 14:00:54 -0500, Andy Lutomirski wrote: > >> Enabling and disabling the vblank interrupt (on devices that >> support it) is cheap. ?So disable it quickly after each >> interrupt. > > So, the concern (and reason for the or

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Jesse Barnes
On Mon, 20 Dec 2010 22:55:46 -0500 Andrew Lutomirski wrote: > On Mon, Dec 20, 2010 at 10:47 PM, Keith Packard wrote: > > On Mon, 20 Dec 2010 22:34:12 -0500, Andrew Lutomirski wrote: > > > >> But five seconds is a *long* time, and anything short enough that the > >> interrupt actually gets turne

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Jesse Barnes
On Mon, 20 Dec 2010 22:55:46 -0500 Andrew Lutomirski wrote: > On Mon, Dec 20, 2010 at 10:47 PM, Keith Packard wrote: > > On Mon, 20 Dec 2010 22:34:12 -0500, Andrew Lutomirski > > wrote: > > > >> But five seconds is a *long* time, and anything short enough that the > >> interrupt actually gets

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Andrew Lutomirski
On Mon, Dec 20, 2010 at 10:47 PM, Keith Packard wrote: > On Mon, 20 Dec 2010 22:34:12 -0500, Andrew Lutomirski wrote: > >> But five seconds is a *long* time, and anything short enough that the >> interrupt actually gets turned off in normal use risks the same race. > > Right, so eliminating any r

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Keith Packard
On Mon, 20 Dec 2010 22:34:12 -0500, Andrew Lutomirski wrote: > But five seconds is a *long* time, and anything short enough that the > interrupt actually gets turned off in normal use risks the same race. Right, so eliminating any race seems like the basic requirement. Can that be done? -- kei

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Keith Packard
On Mon, 20 Dec 2010 22:34:12 -0500, Andrew Lutomirski wrote: > But five seconds is a *long* time, and anything short enough that the > interrupt actually gets turned off in normal use risks the same race. Right, so eliminating any race seems like the basic requirement. Can that be done? -- kei

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Andrew Lutomirski
On Mon, Dec 20, 2010 at 10:23 PM, Keith Packard wrote: > On Mon, 20 Dec 2010 14:00:54 -0500, Andy Lutomirski wrote: > >> Enabling and disabling the vblank interrupt (on devices that >> support it) is cheap.  So disable it quickly after each >> interrupt. > > So, the concern (and reason for the or

Re: [Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Keith Packard
On Mon, 20 Dec 2010 14:00:54 -0500, Andy Lutomirski wrote: > Enabling and disabling the vblank interrupt (on devices that > support it) is cheap. So disable it quickly after each > interrupt. So, the concern (and reason for the original design) was that you might lose count of vblank interrupts

[Intel-gfx] [PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Keith Packard
On Mon, 20 Dec 2010 14:00:54 -0500, Andy Lutomirski wrote: > Enabling and disabling the vblank interrupt (on devices that > support it) is cheap. So disable it quickly after each > interrupt. So, the concern (and reason for the original design) was that you might lose count of vblank interrupts

[PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Andy Lutomirski
Enabling and disabling the vblank interrupt (on devices that support it) is cheap. So disable it quickly after each interrupt. To avoid constantly enabling and disabling vblank when animations are running, after a predefined number (3) of consecutive enabled vblanks that someone cared about, just

[PATCH] drm: Aggressively disable vblanks

2010-12-20 Thread Andy Lutomirski
Enabling and disabling the vblank interrupt (on devices that support it) is cheap. So disable it quickly after each interrupt. To avoid constantly enabling and disabling vblank when animations are running, after a predefined number (3) of consecutive enabled vblanks that someone cared about, just