Re: [PATCH] drm/xe: Fix build error for XE_IOCTL_DBG macro

2024-10-28 Thread gyeyoung
Thank you for your review, I missed how && work. I will revise a patch that print only when cond is true. sincerely, Gyeyoung baek On Tue, Oct 29, 2024 at 4:47 AM Lucas De Marchi wrote: > > On Sun, Oct 27, 2024 at 01:57:52PM +0900, Gyeyoung Baek wrote: > >In the previous code, there is build err

Re: [PATCH] drm/xe: Fix build error for XE_IOCTL_DBG macro

2024-10-28 Thread Lucas De Marchi
On Sun, Oct 27, 2024 at 01:57:52PM +0900, Gyeyoung Baek wrote: In the previous code, there is build error. if CONFIG_DRM_USE_DYNAMIC_DEBUG is set, 'drm_dbg' function is replaced with '__dynamic_func_call_cls', which is replaced with a do while statement. The problem is that, XE_IOCTL_DBG uses th

[PATCH] drm/xe: Fix build error for XE_IOCTL_DBG macro

2024-10-27 Thread Gyeyoung Baek
In the previous code, there is build error. if CONFIG_DRM_USE_DYNAMIC_DEBUG is set, 'drm_dbg' function is replaced with '__dynamic_func_call_cls', which is replaced with a do while statement. The problem is that, XE_IOCTL_DBG uses this function for conditional expression. so I fix the expression