Re: [PATCH] drm/xe/oa/uapi: Make bit masks unsigned

2024-07-30 Thread Lucas De Marchi
On Mon, Jul 29, 2024 at 02:54:58PM GMT, Ashutosh Dixit wrote: On Mon, 29 Jul 2024 06:21:20 -0700, Lucas De Marchi wrote: Hi Lucas, Reviewed-by: Lucas De Marchi That fixes the build, but question to Ashutosh: it's odd to tie the format to a bspec. What happens on next platform if the HW ch

Re: [PATCH] drm/xe/oa/uapi: Make bit masks unsigned

2024-07-29 Thread Dixit, Ashutosh
On Mon, 29 Jul 2024 06:21:20 -0700, Lucas De Marchi wrote: > Hi Lucas, > Reviewed-by: Lucas De Marchi > > That fixes the build, but question to Ashutosh: it's odd to tie the > format to a bspec. What happens on next platform if the HW changes? > Hopefully it doesn't change in an incompatible way

Re: [PATCH] drm/xe/oa/uapi: Make bit masks unsigned

2024-07-29 Thread Lucas De Marchi
On Mon, Jul 29, 2024 at 11:26:34AM GMT, Geert Uytterhoeven wrote: When building with gcc-5: In function ‘decode_oa_format.isra.26’, inlined from ‘xe_oa_set_prop_oa_format’ at drivers/gpu/drm/xe/xe_oa.c:1664:6: ././include/linux/compiler_types.h:510:38: error: call to ‘__compileti

[PATCH] drm/xe/oa/uapi: Make bit masks unsigned

2024-07-29 Thread Geert Uytterhoeven
When building with gcc-5: In function ‘decode_oa_format.isra.26’, inlined from ‘xe_oa_set_prop_oa_format’ at drivers/gpu/drm/xe/xe_oa.c:1664:6: ././include/linux/compiler_types.h:510:38: error: call to ‘__compiletime_assert_1336’ declared with attribute error: FIELD_GET: mask is