Re: [PATCH] drm/xe/display: Fix memleak in display initialization

2024-02-01 Thread Maarten Lankhorst
On 2024-01-31 16:07, Jani Nikula wrote: On Wed, 31 Jan 2024, Lucas De Marchi wrote: +Jani On Fri, Jan 26, 2024 at 11:34:53PM +0800, wangxiaoming321 wrote: intel_power_domains_init has been called twice in xe_device_probe: xe_device_probe -> xe_display_init_nommio -> intel_power_domains_ini

Re: [PATCH] drm/xe/display: Fix memleak in display initialization

2024-01-31 Thread Jani Nikula
On Wed, 31 Jan 2024, Lucas De Marchi wrote: > +Jani > > On Fri, Jan 26, 2024 at 11:34:53PM +0800, wangxiaoming321 wrote: >>intel_power_domains_init has been called twice in xe_device_probe: >>xe_device_probe -> xe_display_init_nommio -> intel_power_domains_init(xe) >>xe_device_probe -> xe_display_

Re: [PATCH] drm/xe/display: Fix memleak in display initialization

2024-01-31 Thread Lucas De Marchi
+Jani On Fri, Jan 26, 2024 at 11:34:53PM +0800, wangxiaoming321 wrote: intel_power_domains_init has been called twice in xe_device_probe: xe_device_probe -> xe_display_init_nommio -> intel_power_domains_init(xe) xe_device_probe -> xe_display_init_noirq -> intel_display_driver_probe_noirq -> inte

[PATCH] drm/xe/display: Fix memleak in display initialization

2024-01-26 Thread wangxiaoming321
intel_power_domains_init has been called twice in xe_device_probe: xe_device_probe -> xe_display_init_nommio -> intel_power_domains_init(xe) xe_device_probe -> xe_display_init_noirq -> intel_display_driver_probe_noirq -> intel_power_domains_init(i915) It needs remove one to avoid power_domains->po

Re: [PATCH] drm/xe/display: Fix memleak in display initialization

2024-01-26 Thread Ville Syrjälä
On Fri, Jan 26, 2024 at 10:34:33PM +0800, wangxiaoming321 wrote: > intel_power_domains_init has been called twice in xe_device_probe: > xe_device_probe -> xe_display_init_nommio -> intel_power_domains_init(xe) > xe_device_probe -> xe_display_init_noirq -> intel_display_driver_probe_noirq > -> intel

[PATCH] drm/xe/display: Fix memleak in display initialization

2024-01-26 Thread wangxiaoming321
intel_power_domains_init has been called twice in xe_device_probe: xe_device_probe -> xe_display_init_nommio -> intel_power_domains_init(xe) xe_device_probe -> xe_display_init_noirq -> intel_display_driver_probe_noirq -> intel_power_domains_init(i915) It needs add a flag to avoid power_domains->po

Re: [PATCH] drm/xe/display: Fix memleak in display initialization

2024-01-25 Thread Jani Nikula
On Thu, 25 Jan 2024, wangxiaoming321 wrote: > In the call stack xe_device_probe -> xe_display_init_nommio -> > intel_power_domains_init > Power_domains hasn't been cleaned up if return error, > which has do the clean in i915_driver_late_release call from > i915_driver_probe. This has nothing

[PATCH] drm/xe/display: Fix memleak in display initialization

2024-01-24 Thread wangxiaoming321
In the call stack xe_device_probe -> xe_display_init_nommio -> intel_power_domains_init Power_domains hasn't been cleaned up if return error, which has do the clean in i915_driver_late_release call from i915_driver_probe. unreferenced object 0x88811150ee00 (size 512): comm "systemd-udevd"