Re: [PATCH] drm/xe/device: clean up on error in probe()

2024-01-05 Thread Matthew Brost
On Fri, Jan 05, 2024 at 03:22:23PM +0300, Dan Carpenter wrote: > This error path should clean up before returning. > > Smatch detected this bug: > drivers/gpu/drm/xe/xe_device.c:487 xe_device_probe() warn: missing unwind > goto? > > Fixes: 4cb12b71923b ("drm/xe/xe2: Determine bios enablement f

[PATCH] drm/xe/device: clean up on error in probe()

2024-01-05 Thread Dan Carpenter
This error path should clean up before returning. Smatch detected this bug: drivers/gpu/drm/xe/xe_device.c:487 xe_device_probe() warn: missing unwind goto? Fixes: 4cb12b71923b ("drm/xe/xe2: Determine bios enablement for flat ccs on igfx") Signed-off-by: Dan Carpenter --- Speeking of static a