Re: [PATCH] drm/vmwgfx_kms: Fix potential NULL pointer dereference

2017-12-06 Thread Gustavo A. R. Silva
Hi Ville, Quoting Ville Syrjälä : On Mon, Dec 04, 2017 at 03:54:18PM -0600, Gustavo A. R. Silva wrote: crtc_state is being null checked in a previous code block, which implies that such pointer might be null. crtc_state is dereferenced in drm_atomic_helper_check_plane_state, hence there is a

Re: [PATCH] drm/vmwgfx_kms: Fix potential NULL pointer dereference

2017-12-05 Thread Ville Syrjälä
On Mon, Dec 04, 2017 at 03:54:18PM -0600, Gustavo A. R. Silva wrote: > crtc_state is being null checked in a previous code block, which implies > that such pointer might be null. > > crtc_state is dereferenced in drm_atomic_helper_check_plane_state, hence > there is a potential null pointer derefe

[PATCH] drm/vmwgfx_kms: Fix potential NULL pointer dereference

2017-12-05 Thread Gustavo A. R. Silva
crtc_state is being null checked in a previous code block, which implies that such pointer might be null. crtc_state is dereferenced in drm_atomic_helper_check_plane_state, hence there is a potential null pointer dereference. Fix this by warning-on and returning -EINVAL in case crtc_state is null