Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-21 Thread Thomas Zimmermann
Hi Am 20.01.22 um 22:28 schrieb Zack Rusin: On Thu, 2022-01-20 at 11:00 +0100, Thomas Zimmermann wrote: If that works, would you consider protecting pci_request_region() with    #if not defined(CONFIG_FB_SIMPLE)    #endif with a FIXME comment? Yes, I think that's a good compromise. I'll r

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-20 Thread Zack Rusin
On Thu, 2022-01-20 at 11:00 +0100, Thomas Zimmermann wrote: > > > > > > If that works, would you consider protecting pci_request_region() > > > with > > >    #if not defined(CONFIG_FB_SIMPLE) > > >    #endif > > > > > > with a FIXME comment? > > > > Yes, I think that's a good compromise. I'll re

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-20 Thread Thomas Zimmermann
Hi Am 20.01.22 um 05:06 schrieb Zack Rusin: [...] kernel: fb0: switching to vmwgfx from simple kernel: Console: switching to colour dummy device 80x25 kernel: vmwgfx :00:0f.0: BAR 2: can't reserve [mem 0x7800- 0x7fff 64bit pref] kernel: vmwgfx: probe of :00:0f.0 failed with erro

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-20 Thread Javier Martinez Canillas
Hello Zack, On 1/20/22 05:06, Zack Rusin wrote: [snip] >>> >>> Hmm, the patch looks good but it doesn't work. After boot: >>> /proc/iomem >>> 5000-7fff : pcie@0x4000 >>>    7800-7fff : :00:0f.0 >>> 7800-782f : BOOTFB >>> >>> and vmwgfx fails on pci_request_re

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Zack Rusin
On Wed, 2022-01-19 at 17:36 +0100, Javier Martinez Canillas wrote: > On 1/19/22 16:50, Thomas Zimmermann wrote: > > [snip] > > > > > > IMHO the best solution is to drop IORESOURCE_BUSY from sysfb > > > > > and have > > > > > drivers register/release the range with _BUSY. That would > > > > > sign

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Zack Rusin
On Wed, 2022-01-19 at 16:50 +0100, Thomas Zimmermann wrote: > Hi > > Am 19.01.22 um 16:12 schrieb Zack Rusin: > > On Wed, 2022-01-19 at 15:00 +0100, Thomas Zimmermann wrote: > > > Hi Zack > > > > > > Am 19.01.22 um 10:13 schrieb Thomas Zimmermann: > > > > Hi > > > > > > > > Am 19.01.22 um 03:15

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Javier Martinez Canillas
On 1/19/22 16:50, Thomas Zimmermann wrote: [snip] IMHO the best solution is to drop IORESOURCE_BUSY from sysfb and have drivers register/release the range with _BUSY. That would signal the memory belongs to the sysfb device but is not busy unless a driver has been bound.

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Thomas Zimmermann
Hi Am 19.01.22 um 16:12 schrieb Zack Rusin: On Wed, 2022-01-19 at 15:00 +0100, Thomas Zimmermann wrote: Hi Zack Am 19.01.22 um 10:13 schrieb Thomas Zimmermann: Hi Am 19.01.22 um 03:15 schrieb Zack Rusin: On Tue, 2022-01-18 at 20:00 +0100, Javier Martinez Canillas wrote: Hello Zack, On 1/1

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Zack Rusin
On Wed, 2022-01-19 at 15:00 +0100, Thomas Zimmermann wrote: > Hi Zack > > Am 19.01.22 um 10:13 schrieb Thomas Zimmermann: > > Hi > > > > Am 19.01.22 um 03:15 schrieb Zack Rusin: > > > On Tue, 2022-01-18 at 20:00 +0100, Javier Martinez Canillas wrote: > > > > Hello Zack, > > > > > > > > On 1/17/2

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Thomas Zimmermann
Hi Am 19.01.22 um 15:24 schrieb Zack Rusin: On Wed, 2022-01-19 at 10:13 +0100, Thomas Zimmermann wrote: Hi Am 19.01.22 um 03:15 schrieb Zack Rusin: On Tue, 2022-01-18 at 20:00 +0100, Javier Martinez Canillas wrote: Hello Zack, On 1/17/22 19:03, Zack Rusin wrote: From: Zack Rusin When sys

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Zack Rusin
On Wed, 2022-01-19 at 10:13 +0100, Thomas Zimmermann wrote: > Hi > > Am 19.01.22 um 03:15 schrieb Zack Rusin: > > On Tue, 2022-01-18 at 20:00 +0100, Javier Martinez Canillas wrote: > > > Hello Zack, > > > > > > On 1/17/22 19:03, Zack Rusin wrote: > > > > From: Zack Rusin > > > > > > > > When sy

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Thomas Zimmermann
Hi Zack Am 19.01.22 um 10:13 schrieb Thomas Zimmermann: Hi Am 19.01.22 um 03:15 schrieb Zack Rusin: On Tue, 2022-01-18 at 20:00 +0100, Javier Martinez Canillas wrote: Hello Zack, On 1/17/22 19:03, Zack Rusin wrote: From: Zack Rusin When sysfb_simple is enabled loading vmwgfx fails because

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Thomas Zimmermann
Hi Am 19.01.22 um 03:15 schrieb Zack Rusin: On Tue, 2022-01-18 at 20:00 +0100, Javier Martinez Canillas wrote: Hello Zack, On 1/17/22 19:03, Zack Rusin wrote: From: Zack Rusin When sysfb_simple is enabled loading vmwgfx fails because the regions are held by the platform. In that case remove

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-19 Thread Thomas Zimmermann
Hi Zack Am 17.01.22 um 19:03 schrieb Zack Rusin: From: Zack Rusin When sysfb_simple is enabled loading vmwgfx fails because the regions are held by the platform. In that case remove_conflicting*_framebuffers only removes the simplefb but not the regions held by sysfb. I don't understand this

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-18 Thread Zack Rusin
On Tue, 2022-01-18 at 20:00 +0100, Javier Martinez Canillas wrote: > Hello Zack, > > On 1/17/22 19:03, Zack Rusin wrote: > > From: Zack Rusin > > > > When sysfb_simple is enabled loading vmwgfx fails because the regions > > are held by the platform. In that case > > remove_conflicting*_framebuff

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-18 Thread Javier Martinez Canillas
On 1/18/22 20:00, Javier Martinez Canillas wrote: > Hello Zack, > > On 1/17/22 19:03, Zack Rusin wrote: >> From: Zack Rusin >> >> When sysfb_simple is enabled loading vmwgfx fails because the regions >> are held by the platform. In that case remove_conflicting*_framebuffers >> only removes the si

Re: [PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-18 Thread Javier Martinez Canillas
Hello Zack, On 1/17/22 19:03, Zack Rusin wrote: > From: Zack Rusin > > When sysfb_simple is enabled loading vmwgfx fails because the regions > are held by the platform. In that case remove_conflicting*_framebuffers > only removes the simplefb but not the regions held by sysfb. > Indeed, that's

[PATCH] drm/vmwgfx: Stop requesting the pci regions

2022-01-17 Thread Zack Rusin
From: Zack Rusin When sysfb_simple is enabled loading vmwgfx fails because the regions are held by the platform. In that case remove_conflicting*_framebuffers only removes the simplefb but not the regions held by sysfb. Like the other drm drivers we need to stop requesting all the pci regions to