Re: [PATCH] drm/vmwgfx: Remove rcu locks from user resources

2023-01-09 Thread Zack Rusin
On Mon, 2023-01-09 at 09:14 +0100, Thomas Zimmermann wrote: > Hi, > > what's the status here. The patch apparently never made it into our repos? Thanks for reminding me about this one! December got in the way. It's in drm-misc- fixes now. z

Re: [PATCH] drm/vmwgfx: Remove rcu locks from user resources

2023-01-09 Thread Thomas Zimmermann
Hi, what's the status here. The patch apparently never made it into our repos? Best regards Thomas Am 07.12.22 um 18:29 schrieb Zack Rusin: From: Zack Rusin User resource lookups used rcu to avoid two extra atomics. Unfortunately the rcu paths were buggy and it was easy to make the driver cr

Re: [PATCH] drm/vmwgfx: Remove rcu locks from user resources

2022-12-07 Thread "Maaz Mombasawala (VMware)
LGTM. Reviewed-by: Maaz Mombasawala On 12/7/22 09:29, Zack Rusin wrote: > From: Zack Rusin > > User resource lookups used rcu to avoid two extra atomics. Unfortunately > the rcu paths were buggy and it was easy to make the driver crash by > submitting command buffers from two different threads

Re: [PATCH] drm/vmwgfx: Remove rcu locks from user resources

2022-12-07 Thread Martin Krastev (VMware)
From: Martin Krastev Looks good! Reviewed-by: Martin Krastev Regards, Martin On 7.12.22 г. 19:29 ч., Zack Rusin wrote: From: Zack Rusin User resource lookups used rcu to avoid two extra atomics. Unfortunately the rcu paths were buggy and it was easy to make the driver crash by submitt

[PATCH] drm/vmwgfx: Remove rcu locks from user resources

2022-12-07 Thread Zack Rusin
From: Zack Rusin User resource lookups used rcu to avoid two extra atomics. Unfortunately the rcu paths were buggy and it was easy to make the driver crash by submitting command buffers from two different threads. Because the lookups never show up in performance profiles replace them with a regul