Re: [PATCH] drm/vmwgfx: NULL pointer dereference from vmw_cmd_dx_view_define()

2019-05-13 Thread Thomas Hellstrom
On Sat, 2019-05-11 at 18:01 +1200, Murray McAllister wrote: > If SVGA_3D_CMD_DX_DEFINE_RENDERTARGET_VIEW is called with a surface > ID of SVGA3D_INVALID_ID, the srf struct will remain NULL after > vmw_cmd_res_check(), leading to a null pointer dereference in > vmw_view_add(). > > Signed-off-by: Mu

[PATCH] drm/vmwgfx: NULL pointer dereference from vmw_cmd_dx_view_define()

2019-05-10 Thread Murray McAllister
If SVGA_3D_CMD_DX_DEFINE_RENDERTARGET_VIEW is called with a surface ID of SVGA3D_INVALID_ID, the srf struct will remain NULL after vmw_cmd_res_check(), leading to a null pointer dereference in vmw_view_add(). Signed-off-by: Murray McAllister --- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4