Re: [PATCH] drm/vmwgfx: Fix src/dst_pitch confusion

2023-03-20 Thread Dave Airlie
On Tue, 21 Mar 2023 at 09:42, Zack Rusin wrote: > > On Tue, 2023-03-21 at 08:46 +1000, Dave Airlie wrote: > > !! External Email > > > > On Thu, 16 Mar 2023 at 01:25, Martin Krastev (VMware) > > wrote: > > > > > > From: Martin Krastev > > > > > > We reviewers botched that one. > > > > > > Reviewe

Re: [PATCH] drm/vmwgfx: Fix src/dst_pitch confusion

2023-03-20 Thread Zack Rusin
On Tue, 2023-03-21 at 08:46 +1000, Dave Airlie wrote: > !! External Email > > On Thu, 16 Mar 2023 at 01:25, Martin Krastev (VMware) > wrote: > > > > From: Martin Krastev > > > > We reviewers botched that one. > > > > Reviewed-by: Martin Krastev > > Can someone land this into drm-misc-next p

Re: [PATCH] drm/vmwgfx: Fix src/dst_pitch confusion

2023-03-20 Thread Dave Airlie
On Thu, 16 Mar 2023 at 01:25, Martin Krastev (VMware) wrote: > > From: Martin Krastev > > We reviewers botched that one. > > Reviewed-by: Martin Krastev Can someone land this into drm-misc-next please so I can start building with clang again? Dave.

Re: [PATCH] drm/vmwgfx: Fix src/dst_pitch confusion

2023-03-15 Thread Martin Krastev (VMware)
From: Martin Krastev We reviewers botched that one. Reviewed-by: Martin Krastev Regards, Martin On 14.03.23 г. 23:14 ч., Zack Rusin wrote: From: Zack Rusin The src/dst_pitch got mixed up during the rework of the function, make sure the offset's refer to the correct one. Spotted by cla

Re: [PATCH] drm/vmwgfx: Fix src/dst_pitch confusion

2023-03-14 Thread Nathan Chancellor
On Tue, Mar 14, 2023 at 05:14:45PM -0400, Zack Rusin wrote: > From: Zack Rusin > > The src/dst_pitch got mixed up during the rework of the function, make > sure the offset's refer to the correct one. > > Spotted by clang: > Clang warns (or errors with CONFIG_WERROR): > > drivers/gpu/drm/vmwgf

[PATCH] drm/vmwgfx: Fix src/dst_pitch confusion

2023-03-14 Thread Zack Rusin
From: Zack Rusin The src/dst_pitch got mixed up during the rework of the function, make sure the offset's refer to the correct one. Spotted by clang: Clang warns (or errors with CONFIG_WERROR): drivers/gpu/drm/vmwgfx/vmwgfx_stdu.c:509:29: error: variable 'dst_pitch' is uninitialized when use