Re: [PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

On Wed, Dec 21, 2022 at 3:45 PM Thorsten Leemhuis wrote: > > Hi, this is your Linux kernel regression tracker. The relevant code here > is not my area of expertise, nevertheless a few questions: Thank you > > On 21.12.22 03:23, Kaiwan N Billimoria wrote: > > [REGRESSION] ? > > > Testing with 6.1,

Re: [PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct #forregzbot

[Note: this mail contains only information for Linux kernel regression tracking. Mails like these contain '#forregzbot' in the subject to make then easy to spot and filter out. The author also tried to remove most or all individuals from the list of recipients to spare them the hassle.] On 21.12.2

Re: [PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

Hi, this is your Linux kernel regression tracker. The relevant code here is not my area of expertise, nevertheless a few questions: On 21.12.22 03:23, Kaiwan N Billimoria wrote: > [REGRESSION] ? > Testing with 6.1, I find the same issue - VirtualBox VMs seem to hang > on boot, though the kernel h

Re: [PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

[REGRESSION] ? Hi, Testing with 6.1, I find the same issue - VirtualBox VMs seem to hang on boot, though the kernel has this patch applied of course... Am running VirtualBox 7.0.4 on an x86_64 Linux (Ubuntu 22.04.1) host; the system hangs on boot with the screen going blank. Passing 'nomodeset' via

Re: [PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

On Fri, 2022-05-13 at 16:18 +0200, Hans de Goede wrote: > Hi, > > On 5/13/22 15:25, Zack Rusin wrote: > > > > > > > On May 13, 2022, at 3:43 AM, Thorsten Leemhuis > > > mailto:regressi...@leemhuis.info>> wrote: > > > > > > CCing airlied > > > > > > On 09.05.22 14:02, Javier Martinez Canillas w

Re: [PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

Hi, On 5/13/22 15:25, Zack Rusin wrote: > > >> On May 13, 2022, at 3:43 AM, Thorsten Leemhuis > > wrote: >> >> CCing airlied >> >> On 09.05.22 14:02, Javier Martinez Canillas wrote: >>> On 5/9/22 13:55, Hans de Goede wrote: >>> [snip] >> >> Fixes: dabdcd

Re: [PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

On 13.05.22 15:25, Zack Rusin wrote: >> On May 13, 2022, at 3:43 AM, Thorsten Leemhuis >> mailto:regressi...@leemhuis.info>> wrote: >> >> CCing airlied >> >> On 09.05.22 14:02, Javier Martinez Canillas wrote: >>> On 5/9/22 13:55, Hans de Goede wrote: >>> [snip] >> >> Fixes: dabdcdc9822a ("d

Re: [PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

On May 13, 2022, at 3:43 AM, Thorsten Leemhuis mailto:regressi...@leemhuis.info>> wrote: CCing airlied On 09.05.22 14:02, Javier Martinez Canillas wrote: On 5/9/22 13:55, Hans de Goede wrote: [snip] Fixes: dabdcdc9822a ("drm/vmwgfx: Switch to mode_cmd2") BugLink: https://nam04.safelinks.prot

Re: [PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

CCing airlied On 09.05.22 14:02, Javier Martinez Canillas wrote: > On 5/9/22 13:55, Hans de Goede wrote: > [snip] Fixes: dabdcdc9822a ("drm/vmwgfx: Switch to mode_cmd2") BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=2072556 Signed-off-by: Hans de Goede --- >>> >>>

Re: [PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

On 5/9/22 13:55, Hans de Goede wrote: [snip] >>> >>> Fixes: dabdcdc9822a ("drm/vmwgfx: Switch to mode_cmd2") >>> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=2072556 >>> Signed-off-by: Hans de Goede >>> --- >> >> Zack fixed this already: >> >> https://cgit.freedesktop.org/drm/drm-misc/co

Re: [PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

Hi, On 5/9/22 13:52, Javier Martinez Canillas wrote: > Hello Hans, > > On 5/9/22 13:04, Hans de Goede wrote: >> vmw_fb_kms_framebuffer() declares a drm_mode_fb_cmd2 struct on the stack >> without zero-ing it and then continues with initializing only some fields. >> >> This leads to drm_mode_fb_cm

Re: [PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

Hello Hans, On 5/9/22 13:04, Hans de Goede wrote: > vmw_fb_kms_framebuffer() declares a drm_mode_fb_cmd2 struct on the stack > without zero-ing it and then continues with initializing only some fields. > > This leads to drm_mode_fb_cmd2.modifiers[0] containing garbage, > which eventually gets use

[PATCH] drm/vmwgfx: Fix passing partly uninitialized drm_mode_fb_cmd2 struct

vmw_fb_kms_framebuffer() declares a drm_mode_fb_cmd2 struct on the stack without zero-ing it and then continues with initializing only some fields. This leads to drm_mode_fb_cmd2.modifiers[0] containing garbage, which eventually gets used by drm_helper_mode_fill_fb_struct() to set fb->modifier whe