Re: [PATCH] drm/vmwgfx: Fix dumb buffer leak

2025-01-30 Thread Ian Forbes
On Tue, Jan 21, 2025 at 1:42 PM Zack Rusin wrote: > > > Ah, that makes sense. If you could improve the commit message that'd > be great (just describe both issues. i.e. the buffer handle being > allocated via vmw_gem_object_create_with_handle which create a gem > handle that holds the reference an

Re: [PATCH] drm/vmwgfx: Fix dumb buffer leak

2025-01-21 Thread Zack Rusin
On Tue, Jan 21, 2025 at 2:11 PM Ian Forbes wrote: > > On Fri, Jan 17, 2025 at 1:20 PM Zack Rusin wrote: > > > > You're going to have to explain that one in the commit message a lot > > better because as is it doesn't make sense to me. Especially the > > !vbo->is_dumb in vmw_bo_free. > > > > z > >

Re: [PATCH] drm/vmwgfx: Fix dumb buffer leak

2025-01-21 Thread Ian Forbes
On Fri, Jan 17, 2025 at 1:20 PM Zack Rusin wrote: > > You're going to have to explain that one in the commit message a lot > better because as is it doesn't make sense to me. Especially the > !vbo->is_dumb in vmw_bo_free. > > z The dirty tracker is freed later in vmw_bo_release when it's a cohere

Re: [PATCH] drm/vmwgfx: Fix dumb buffer leak

2025-01-17 Thread Zack Rusin
On Fri, Jan 17, 2025 at 2:14 PM Ian Forbes wrote: > > Fixes: d6667f0ddf46 ("drm/vmwgfx: Fix handling of dumb buffers") > Signed-off-by: Ian Forbes > --- > drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 2 +- > drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 1 + > 2 files changed, 2 insertions(+), 1 deleti

[PATCH] drm/vmwgfx: Fix dumb buffer leak

2025-01-17 Thread Ian Forbes
Fixes: d6667f0ddf46 ("drm/vmwgfx: Fix handling of dumb buffers") Signed-off-by: Ian Forbes --- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_surface.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_bo.c b/drivers