Re: [PATCH] drm/vmwgfx: Don't look at state->allow_modeset

2019-06-28 Thread Daniel Vetter
On Tue, May 21, 2019 at 02:58:36PM +, Deepak Singh Rawat wrote: > Reviewed-by: Deepak Rawat Thanks for your review, I've merged this into drm-misc-next so it won't get lost again. Should land for 5.4. -Daniel > > On Tue, 2019-05-21 at 00:35 +0200, Daniel Vetter wrote: > > That's purely for

Re: [PATCH] drm/vmwgfx: Don't look at state->allow_modeset

2019-05-21 Thread Deepak Singh Rawat
Reviewed-by: Deepak Rawat On Tue, 2019-05-21 at 00:35 +0200, Daniel Vetter wrote: > That's purely for the uapi layer to implement the ALLOW_MODESET flag. > > Drivers should instead look at the state, e.g. through > drm_atomic_crtc_needs_modeset(), which vmwgfx already does. Also > remove > the c

[PATCH] drm/vmwgfx: Don't look at state->allow_modeset

2019-05-20 Thread Daniel Vetter
That's purely for the uapi layer to implement the ALLOW_MODESET flag. Drivers should instead look at the state, e.g. through drm_atomic_crtc_needs_modeset(), which vmwgfx already does. Also remove the confusing comment, since checking allow_modeset is at best a micro optimization. v2: Rebase Sig