Re: [PATCH] drm/vkms: introduce prepare_fb and cleanup_fb functions

2023-01-06 Thread Daniel Vetter
On Fri, Jan 06, 2023 at 08:34:13AM -0300, Maíra Canal wrote: > Hi, > > Thanks for the review! > > On 1/6/23 05:10, Thomas Zimmermann wrote: > > Hi > > > > Am 05.01.23 um 19:43 schrieb Melissa Wen: > > > On 01/05, Maíra Canal wrote: > > > > With commit 359c6649cd9a ("drm/gem: Implement shadow-pla

Re: [PATCH] drm/vkms: introduce prepare_fb and cleanup_fb functions

2023-01-06 Thread Thomas Zimmermann
Hi Am 06.01.23 um 12:34 schrieb Maíra Canal: Hi, Thanks for the review! On 1/6/23 05:10, Thomas Zimmermann wrote: Hi Am 05.01.23 um 19:43 schrieb Melissa Wen: On 01/05, Maíra Canal wrote: With commit 359c6649cd9a ("drm/gem: Implement shadow-plane {begin, end}_fb_access with vmap"), the beh

Re: [PATCH] drm/vkms: introduce prepare_fb and cleanup_fb functions

2023-01-06 Thread Maíra Canal
Hi, Thanks for the review! On 1/6/23 05:10, Thomas Zimmermann wrote: Hi Am 05.01.23 um 19:43 schrieb Melissa Wen: On 01/05, Maíra Canal wrote: With commit 359c6649cd9a ("drm/gem: Implement shadow-plane {begin, end}_fb_access with vmap"), the behavior of the shadow-plane helpers changed and t

Re: [PATCH] drm/vkms: introduce prepare_fb and cleanup_fb functions

2023-01-06 Thread Daniel Vetter
On Fri, Jan 06, 2023 at 09:10:17AM +0100, Thomas Zimmermann wrote: > Hi > > Am 05.01.23 um 19:43 schrieb Melissa Wen: > > On 01/05, Maíra Canal wrote: > > > With commit 359c6649cd9a ("drm/gem: Implement shadow-plane {begin, > > > end}_fb_access with vmap"), the behavior of the shadow-plane helpers

Re: [PATCH] drm/vkms: introduce prepare_fb and cleanup_fb functions

2023-01-06 Thread Thomas Zimmermann
Hi Am 05.01.23 um 19:43 schrieb Melissa Wen: On 01/05, Maíra Canal wrote: With commit 359c6649cd9a ("drm/gem: Implement shadow-plane {begin, end}_fb_access with vmap"), the behavior of the shadow-plane helpers changed and the vunmap is now performed at the end of the current pageflip, instead o

Re: [PATCH] drm/vkms: introduce prepare_fb and cleanup_fb functions

2023-01-05 Thread Melissa Wen
On 01/05, Maíra Canal wrote: > With commit 359c6649cd9a ("drm/gem: Implement shadow-plane {begin, > end}_fb_access with vmap"), the behavior of the shadow-plane helpers > changed and the vunmap is now performed at the end of > the current pageflip, instead of the end of the following pageflip. > >

[PATCH] drm/vkms: introduce prepare_fb and cleanup_fb functions

2023-01-05 Thread Maíra Canal
With commit 359c6649cd9a ("drm/gem: Implement shadow-plane {begin, end}_fb_access with vmap"), the behavior of the shadow-plane helpers changed and the vunmap is now performed at the end of the current pageflip, instead of the end of the following pageflip. By performing the vunmap at the end of t