Re: [PATCH] drm/vkms: add support for gamma_set interface

2020-09-02 Thread Ville Syrjälä
On Wed, Sep 02, 2020 at 09:09:11AM +, Simon Ser wrote: > On Tuesday, September 1, 2020 3:26 PM, Daniel Vetter wrote: > > > On Tue, Sep 01, 2020 at 08:57:37AM +, Simon Ser wrote: > > > > > On Monday, August 31, 2020 3:48 PM, Ville Syrjälä > > > ville.syrj...@linux.intel.com wrote: > > > >

Re: [PATCH] drm/vkms: add support for gamma_set interface

2020-09-02 Thread Simon Ser
On Tuesday, September 1, 2020 3:26 PM, Daniel Vetter wrote: > On Tue, Sep 01, 2020 at 08:57:37AM +, Simon Ser wrote: > > > On Monday, August 31, 2020 3:48 PM, Ville Syrjälä > > ville.syrj...@linux.intel.com wrote: > > > > > > > It doesn't seem like this IGT test's goal is to exercise support

Re: [PATCH] drm/vkms: add support for gamma_set interface

2020-09-01 Thread Daniel Vetter
On Tue, Sep 01, 2020 at 08:57:37AM +, Simon Ser wrote: > On Monday, August 31, 2020 3:48 PM, Ville Syrjälä > wrote: > > > > > It doesn't seem like this IGT test's goal is to exercise support for > > > > gamma LUTs. Does the test just tries to reset the gamma LUT to linear? > > > > If so, I t

Re: [PATCH] drm/vkms: add support for gamma_set interface

2020-09-01 Thread Simon Ser
On Monday, August 31, 2020 3:48 PM, Ville Syrjälä wrote: > > > It doesn't seem like this IGT test's goal is to exercise support for > > > gamma LUTs. Does the test just tries to reset the gamma LUT to linear? > > > If so, I think the IGT test should be fixed to ignore "I don't support > > > gamm

Re: [PATCH] drm/vkms: add support for gamma_set interface

2020-08-31 Thread Ville Syrjälä
On Mon, Aug 31, 2020 at 01:38:58PM +, Sidong Yang wrote: > On Mon, Aug 31, 2020 at 11:39:10AM +, Simon Ser wrote: > > On Saturday, August 29, 2020 4:06 PM, Sidong Yang > > wrote: > > > > > Currently vkms module doesn't support gamma function for userspace. so igt > > > subtests in kms_pl

Re: [PATCH] drm/vkms: add support for gamma_set interface

2020-08-31 Thread Sidong Yang
On Mon, Aug 31, 2020 at 11:39:10AM +, Simon Ser wrote: > On Saturday, August 29, 2020 4:06 PM, Sidong Yang wrote: > > > Currently vkms module doesn't support gamma function for userspace. so igt > > subtests in kms_plane(pixel-format-pipe-A-plan) failed for calling > > drmModeCrtcSetGamma().

Re: [PATCH] drm/vkms: add support for gamma_set interface

2020-08-31 Thread Simon Ser
On Saturday, August 29, 2020 4:06 PM, Sidong Yang wrote: > Currently vkms module doesn't support gamma function for userspace. so igt > subtests in kms_plane(pixel-format-pipe-A-plan) failed for calling > drmModeCrtcSetGamma(). It doesn't seem like this IGT test's goal is to exercise support for

[PATCH] drm/vkms: add support for gamma_set interface

2020-08-29 Thread Sidong Yang
Currently vkms module doesn't support gamma function for userspace. so igt subtests in kms_plane(pixel-format-pipe-A-plan) failed for calling drmModeCrtcSetGamma(). This patch set gamma_set interface in vkms_crtc_funcs for support gamma function. With initializing crtc, added calls for setting gamm