Re: [PATCH] drm/vkms: Solve bug on kms_crc_cursor tests

2019-03-18 Thread Rodrigo Siqueira
On 03/15, Ville Syrjälä wrote: > On Fri, Mar 15, 2019 at 08:51:57AM -0300, Rodrigo Siqueira wrote: > > On 03/11, Ville Syrjälä wrote: > > > On Sun, Mar 10, 2019 at 05:35:05PM -0300, Rodrigo Siqueira wrote: > > > > On 03/01, Ville Syrjälä wrote: > > > > > On Fri, Mar 01, 2019 at 03:35:35PM -0300, Sh

Re: [PATCH] drm/vkms: Solve bug on kms_crc_cursor tests

2019-03-15 Thread Ville Syrjälä
On Fri, Mar 15, 2019 at 08:51:57AM -0300, Rodrigo Siqueira wrote: > On 03/11, Ville Syrjälä wrote: > > On Sun, Mar 10, 2019 at 05:35:05PM -0300, Rodrigo Siqueira wrote: > > > On 03/01, Ville Syrjälä wrote: > > > > On Fri, Mar 01, 2019 at 03:35:35PM -0300, Shayenne Moura wrote: > > > > > Em sex, 1 d

Re: [PATCH] drm/vkms: Solve bug on kms_crc_cursor tests

2019-03-15 Thread Rodrigo Siqueira
On 03/11, Ville Syrjälä wrote: > On Sun, Mar 10, 2019 at 05:35:05PM -0300, Rodrigo Siqueira wrote: > > On 03/01, Ville Syrjälä wrote: > > > On Fri, Mar 01, 2019 at 03:35:35PM -0300, Shayenne Moura wrote: > > > > Em sex, 1 de mar de 2019 às 12:26, Ville Syrjälä > > > > escreveu: > > > > > > > > > >

Re: [PATCH] drm/vkms: Solve bug on kms_crc_cursor tests

2019-03-11 Thread Ville Syrjälä
On Sun, Mar 10, 2019 at 05:35:05PM -0300, Rodrigo Siqueira wrote: > On 03/01, Ville Syrjälä wrote: > > On Fri, Mar 01, 2019 at 03:35:35PM -0300, Shayenne Moura wrote: > > > Em sex, 1 de mar de 2019 às 12:26, Ville Syrjälä > > > escreveu: > > > > > > > > On Fri, Mar 01, 2019 at 11:55:11AM -0300, Sh

Re: [PATCH] drm/vkms: Solve bug on kms_crc_cursor tests

2019-03-10 Thread Rodrigo Siqueira
On 03/01, Ville Syrjälä wrote: > On Fri, Mar 01, 2019 at 03:35:35PM -0300, Shayenne Moura wrote: > > Em sex, 1 de mar de 2019 às 12:26, Ville Syrjälä > > escreveu: > > > > > > On Fri, Mar 01, 2019 at 11:55:11AM -0300, Shayenne Moura wrote: > > > > Em qui, 28 de fev de 2019 às 11:03, Ville Syrjälä

Re: [PATCH] drm/vkms: Solve bug on kms_crc_cursor tests

2019-03-01 Thread Ville Syrjälä
On Fri, Mar 01, 2019 at 03:35:35PM -0300, Shayenne Moura wrote: > Em sex, 1 de mar de 2019 às 12:26, Ville Syrjälä > escreveu: > > > > On Fri, Mar 01, 2019 at 11:55:11AM -0300, Shayenne Moura wrote: > > > Em qui, 28 de fev de 2019 às 11:03, Ville Syrjälä > > > escreveu: > > > > > > > > On Thu, Fe

Re: [PATCH] drm/vkms: Solve bug on kms_crc_cursor tests

2019-03-01 Thread Shayenne Moura
Em sex, 1 de mar de 2019 às 12:26, Ville Syrjälä escreveu: > > On Fri, Mar 01, 2019 at 11:55:11AM -0300, Shayenne Moura wrote: > > Em qui, 28 de fev de 2019 às 11:03, Ville Syrjälä > > escreveu: > > > > > > On Thu, Feb 28, 2019 at 11:11:07AM +0100, Daniel Vetter wrote: > > > > On Mon, Feb 25, 201

Re: [PATCH] drm/vkms: Solve bug on kms_crc_cursor tests

2019-03-01 Thread Ville Syrjälä
On Fri, Mar 01, 2019 at 11:55:11AM -0300, Shayenne Moura wrote: > Em qui, 28 de fev de 2019 às 11:03, Ville Syrjälä > escreveu: > > > > On Thu, Feb 28, 2019 at 11:11:07AM +0100, Daniel Vetter wrote: > > > On Mon, Feb 25, 2019 at 11:26:06AM -0300, Shayenne Moura wrote: > > > > vkms_crc_work_handle

Re: [PATCH] drm/vkms: Solve bug on kms_crc_cursor tests

2019-03-01 Thread Shayenne Moura
Em qui, 28 de fev de 2019 às 11:03, Ville Syrjälä escreveu: > > On Thu, Feb 28, 2019 at 11:11:07AM +0100, Daniel Vetter wrote: > > On Mon, Feb 25, 2019 at 11:26:06AM -0300, Shayenne Moura wrote: > > > vkms_crc_work_handle needs the value of the actual frame to > > > schedule the workqueue that cal

Re: [PATCH] drm/vkms: Solve bug on kms_crc_cursor tests

2019-02-28 Thread Ville Syrjälä
On Thu, Feb 28, 2019 at 11:11:07AM +0100, Daniel Vetter wrote: > On Mon, Feb 25, 2019 at 11:26:06AM -0300, Shayenne Moura wrote: > > vkms_crc_work_handle needs the value of the actual frame to > > schedule the workqueue that calls periodically the vblank > > handler and the destroy state functions.

Re: [PATCH] drm/vkms: Solve bug on kms_crc_cursor tests

2019-02-28 Thread Daniel Vetter
On Thu, Feb 28, 2019 at 11:11:07AM +0100, Daniel Vetter wrote: > On Mon, Feb 25, 2019 at 11:26:06AM -0300, Shayenne Moura wrote: > > vkms_crc_work_handle needs the value of the actual frame to > > schedule the workqueue that calls periodically the vblank > > handler and the destroy state functions.

Re: [PATCH] drm/vkms: Solve bug on kms_crc_cursor tests

2019-02-28 Thread Daniel Vetter
On Mon, Feb 25, 2019 at 11:26:06AM -0300, Shayenne Moura wrote: > vkms_crc_work_handle needs the value of the actual frame to > schedule the workqueue that calls periodically the vblank > handler and the destroy state functions. However, the frame > value returned from vkms_vblank_simulate is updat

Re: [PATCH] drm/vkms: Solve bug on kms_crc_cursor tests

2019-02-25 Thread Rodrigo Siqueira
Hi, First of all, thanks for your patch! I think you figured out the reason for the extra frame problems :) The patch worked like a charm. Almost all of the tests in kms_flip are passing, and the tests related to kms_cursor_crc are working again \o/ I just have some cosmetic comments inline. O

[PATCH] drm/vkms: Solve bug on kms_crc_cursor tests

2019-02-25 Thread Shayenne Moura
vkms_crc_work_handle needs the value of the actual frame to schedule the workqueue that calls periodically the vblank handler and the destroy state functions. However, the frame value returned from vkms_vblank_simulate is updated and diminished in vblank_get_timestamp because it is not in a vblank