Re: [PATCH] drm/vkms: Fix race condition around accessing frame number

2018-09-03 Thread Daniel Vetter
On Sat, Sep 01, 2018 at 08:53:52PM +0300, Haneen Mohammed wrote: > On Fri, Aug 31, 2018 at 10:41:40AM +0200, Daniel Vetter wrote: > > On Fri, Aug 24, 2018 at 02:16:34AM +0300, Haneen Mohammed wrote: > > > crtc_state is accessed by both vblank_handle() and the ordered > > > work_struct handle vkms_c

Re: [PATCH] drm/vkms: Fix race condition around accessing frame number

2018-09-02 Thread Haneen Mohammed
On Fri, Aug 31, 2018 at 10:41:40AM +0200, Daniel Vetter wrote: > On Fri, Aug 24, 2018 at 02:16:34AM +0300, Haneen Mohammed wrote: > > crtc_state is accessed by both vblank_handle() and the ordered > > work_struct handle vkms_crc_work_handle() to retrieve and or update > > the frame number for compu

Re: [PATCH] drm/vkms: Fix race condition around accessing frame number

2018-08-31 Thread Daniel Vetter
On Fri, Aug 24, 2018 at 02:16:34AM +0300, Haneen Mohammed wrote: > crtc_state is accessed by both vblank_handle() and the ordered > work_struct handle vkms_crc_work_handle() to retrieve and or update > the frame number for computed CRC. > > Since work_struct can fail, add frame_end to account for

[PATCH] drm/vkms: Fix race condition around accessing frame number

2018-08-24 Thread Haneen Mohammed
crtc_state is accessed by both vblank_handle() and the ordered work_struct handle vkms_crc_work_handle() to retrieve and or update the frame number for computed CRC. Since work_struct can fail, add frame_end to account for missing frame numbers. use atomic_t witth appropriate flags for synchroniz