Re: [PATCH] drm/vkms: Drop unnecessary call to drm_crtc_cleanup()

2024-11-04 Thread Louis Chauvet
On 31/10/24 - 19:38, José Expósito wrote: > CRTC creation uses drmm_crtc_init_with_planes(), which automatically > handles cleanup. However, an unnecessary call to drm_crtc_cleanup() is > still present in the vkms_output_init() error path. > > Fixes: 99cc528ebe92 ("drm/vkms: Use drmm_crtc_init_wit

Re: [PATCH] drm/vkms: Drop unnecessary call to drm_crtc_cleanup()

2024-11-01 Thread Maíra Canal
Hi José, On 31/10/24 15:38, José Expósito wrote: CRTC creation uses drmm_crtc_init_with_planes(), which automatically handles cleanup. However, an unnecessary call to drm_crtc_cleanup() is still present in the vkms_output_init() error path. Fixes: 99cc528ebe92 ("drm/vkms: Use drmm_crtc_init_wit

Re: [PATCH] drm/vkms: Drop unnecessary call to drm_crtc_cleanup()

2024-10-31 Thread Louis Chauvet
On 31/10/24 - 19:38, José Expósito wrote: > CRTC creation uses drmm_crtc_init_with_planes(), which automatically > handles cleanup. However, an unnecessary call to drm_crtc_cleanup() is > still present in the vkms_output_init() error path. Thanks! I discussed about this with Maíra on Monday, I ag

[PATCH] drm/vkms: Drop unnecessary call to drm_crtc_cleanup()

2024-10-31 Thread José Expósito
CRTC creation uses drmm_crtc_init_with_planes(), which automatically handles cleanup. However, an unnecessary call to drm_crtc_cleanup() is still present in the vkms_output_init() error path. Fixes: 99cc528ebe92 ("drm/vkms: Use drmm_crtc_init_with_planes()") Signed-off-by: José Expósito --- driv