On 2023/7/12 14:36, Dan Carpenter wrote:
On Wed, Jul 12, 2023 at 09:18:42AM +0800, Su Hui wrote:
On 2023/7/11 19:13, Dan Carpenter wrote:
On Tue, Jul 11, 2023 at 05:00:31PM +0800, Su Hui wrote:
virtio_gpu_get_vbuf always be successful,
so remove the error judgment.
No, just ignore the stati
On Wed, Jul 12, 2023 at 09:18:42AM +0800, Su Hui wrote:
> On 2023/7/11 19:13, Dan Carpenter wrote:
> > On Tue, Jul 11, 2023 at 05:00:31PM +0800, Su Hui wrote:
> > > virtio_gpu_get_vbuf always be successful,
> > > so remove the error judgment.
> > >
> > No, just ignore the static checker false posi
On 2023/7/11 17:33, Markus Elfring wrote:
virtio_gpu_get_vbuf always be successful,
so remove the error judgment.
How do you think about to improve this change description any more?
Hi,
virtio_gpu_get_vbuf use "__GFP_NOFAIL" flag to allocate memory, this
make sure
it won't fail, and virtio
On 2023/7/11 19:13, Dan Carpenter wrote:
On Tue, Jul 11, 2023 at 05:00:31PM +0800, Su Hui wrote:
virtio_gpu_get_vbuf always be successful,
so remove the error judgment.
No, just ignore the static checker false positive in this case. The
intent of the code is clear that if it did have an error
On Tue, Jul 11, 2023 at 05:00:31PM +0800, Su Hui wrote:
> virtio_gpu_get_vbuf always be successful,
> so remove the error judgment.
>
No, just ignore the static checker false positive in this case. The
intent of the code is clear that if it did have an error it should
return an error pointer.
r
> virtio_gpu_get_vbuf always be successful,
> so remove the error judgment.
How do you think about to improve this change description any more?
Regards,
Markus
virtio_gpu_get_vbuf always be successful,
so remove the error judgment.
Signed-off-by: Su Hui
---
drivers/gpu/drm/virtio/virtgpu_vq.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c
b/drivers/gpu/drm/virtio/virtgpu_vq.c
index b1a00c0c25a7..7a2680b3f1a7
