Re: [PATCH] drm/vc4: simplify exit path of a failed allocation of dsi_connector

2017-02-07 Thread Eric Anholt
Colin King writes: > From: Colin Ian King > > If dsi_connector fails to allocate, the exit path via label 'fail' > checks if connector is null, which it always is, so the cleanup > that destroys connector is never going to be called. Hence the > failure path can be more optimally performed by r

Re: [PATCH] drm/vc4: simplify exit path of a failed allocation of dsi_connector

2017-02-06 Thread Gustavo Padovan
Hi Colin, 2017-02-03 Colin King : > From: Colin Ian King > > If dsi_connector fails to allocate, the exit path via label 'fail' > checks if connector is null, which it always is, so the cleanup > that destroys connector is never going to be called. Hence the > failure path can be more optimall

[PATCH] drm/vc4: simplify exit path of a failed allocation of dsi_connector

2017-02-03 Thread Colin King
From: Colin Ian King If dsi_connector fails to allocate, the exit path via label 'fail' checks if connector is null, which it always is, so the cleanup that destroys connector is never going to be called. Hence the failure path can be more optimally performed by removing this and just returning