Re: [PATCH] drm/vc4: fix vc4_atomic_commit_tail() logic

2021-06-08 Thread Maxime Ripard
Hi, On Tue, Jun 08, 2021 at 09:55:12AM +0100, Mark Rutland wrote: > In vc4_atomic_commit_tail() we iterate of the set of old CRTCs, and > attempt to wait on any channels which are still in use. When we iterate > over the CRTCs, we have: > > * `i` - the index of the CRTC > * `channel` - the channe

Re: [PATCH] drm/vc4: fix vc4_atomic_commit_tail() logic

2021-06-08 Thread Marek Szyprowski
On 08.06.2021 10:55, Mark Rutland wrote: > In vc4_atomic_commit_tail() we iterate of the set of old CRTCs, and > attempt to wait on any channels which are still in use. When we iterate > over the CRTCs, we have: > > * `i` - the index of the CRTC > * `channel` - the channel a CRTC is using > > Whe

Re: [PATCH] drm/vc4: fix vc4_atomic_commit_tail() logic

2021-06-08 Thread Arnd Bergmann
On Tue, Jun 8, 2021 at 10:56 AM Mark Rutland wrote: > > In vc4_atomic_commit_tail() we iterate of the set of old CRTCs, and > attempt to wait on any channels which are still in use. When we iterate > over the CRTCs, we have: > > * `i` - the index of the CRTC > * `channel` - the channel a CRTC is u

[PATCH] drm/vc4: fix vc4_atomic_commit_tail() logic

2021-06-08 Thread Mark Rutland
In vc4_atomic_commit_tail() we iterate of the set of old CRTCs, and attempt to wait on any channels which are still in use. When we iterate over the CRTCs, we have: * `i` - the index of the CRTC * `channel` - the channel a CRTC is using When we check the channel state, we consult: old_hvs_stat