[PATCH] drm/vc4: fix ref count leak in vc4_dsi_encoder_enable

2020-06-15 Thread Navid Emamdoost
in vc4_dsi_encoder_enable, the call to pm_runtime_get_sync increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/vc4/vc4_dsi.c | 10 ++ 1 file change

Re: [PATCH] drm/vc4: fix ref count leak in vc4_dsi_encoder_enable

2020-06-15 Thread Markus Elfring
> in vc4_dsi_encoder_enable, the call to pm_runtime_get_sync increments > the counter even in case of failure, leading to incorrect > ref count. In case of failure, decrement the ref count before returning. * Can the term “reference count” become relevant also for this commit message besides oth

Re: [PATCH] drm/vc4: fix ref count leak in vc4_dsi_encoder_enable

2020-06-15 Thread Navid Emamdoost
On Sun, Jun 14, 2020 at 7:32 AM Andy Shevchenko wrote: > > On Sun, Jun 14, 2020 at 9:55 AM Navid Emamdoost > wrote: > > > > in vc4_dsi_encoder_enable, the call to pm_runtime_get_sync increments > > the counter even in case of failure, leading to incorrect > > ref count. In case of failure, decrem

Re: [PATCH] drm/vc4: fix ref count leak in vc4_dsi_encoder_enable

2020-06-14 Thread Andy Shevchenko
On Sun, Jun 14, 2020 at 9:55 AM Navid Emamdoost wrote: > > in vc4_dsi_encoder_enable, the call to pm_runtime_get_sync increments > the counter even in case of failure, leading to incorrect > ref count. In case of failure, decrement the ref count before returning. ... > +out: > + pm_runtime