Re: [PATCH] drm/vc4: Ignore alpha on primary plane

2018-03-05 Thread Stefan Schake
On Mon, Mar 5, 2018 at 10:15 PM, Eric Anholt wrote: > Stefan Schake writes: > >> We allow alpha formats on the primary plane but a partially transparent >> framebuffer will cause a corrupted display. With this change black pixels >> are output instead, in line with the behavior for other DRM driv

Re: [PATCH] drm/vc4: Ignore alpha on primary plane

2018-03-05 Thread Eric Anholt
Stefan Schake writes: > We allow alpha formats on the primary plane but a partially transparent > framebuffer will cause a corrupted display. With this change black pixels > are output instead, in line with the behavior for other DRM drivers. > > Signed-off-by: Stefan Schake > --- > Test program

Re: [PATCH] drm/vc4: Ignore alpha on primary plane

2018-03-02 Thread Ville Syrjälä
On Fri, Mar 02, 2018 at 09:13:14AM -0800, Eric Anholt wrote: > Ville Syrjälä writes: > > > On Fri, Mar 02, 2018 at 04:06:58PM +0100, Stefan Schake wrote: > >> Hey Ville, > >> > >> On Fri, Mar 2, 2018 at 3:43 PM, Ville Syrjälä > >> wrote: > >> > On Fri, Mar 02, 2018 at 04:39:22PM +0200, Ville Sy

Re: [PATCH] drm/vc4: Ignore alpha on primary plane

2018-03-02 Thread Eric Anholt
Ville Syrjälä writes: > On Fri, Mar 02, 2018 at 04:06:58PM +0100, Stefan Schake wrote: >> Hey Ville, >> >> On Fri, Mar 2, 2018 at 3:43 PM, Ville Syrjälä >> wrote: >> > On Fri, Mar 02, 2018 at 04:39:22PM +0200, Ville Syrjälä wrote: >> >> If you want the plane to always be opaque you shouldn't ex

Re: [PATCH] drm/vc4: Ignore alpha on primary plane

2018-03-02 Thread Ville Syrjälä
On Fri, Mar 02, 2018 at 04:48:03PM +0100, Stefan Schake wrote: > On Fri, Mar 2, 2018 at 4:21 PM, Ville Syrjälä > wrote: > > On Fri, Mar 02, 2018 at 04:06:58PM +0100, Stefan Schake wrote: > >> Hey Ville, > >> > >> On Fri, Mar 2, 2018 at 3:43 PM, Ville Syrjälä > >> wrote: > >> > On Fri, Mar 02, 201

Re: [PATCH] drm/vc4: Ignore alpha on primary plane

2018-03-02 Thread Stefan Schake
On Fri, Mar 2, 2018 at 4:21 PM, Ville Syrjälä wrote: > On Fri, Mar 02, 2018 at 04:06:58PM +0100, Stefan Schake wrote: >> Hey Ville, >> >> On Fri, Mar 2, 2018 at 3:43 PM, Ville Syrjälä >> wrote: >> > On Fri, Mar 02, 2018 at 04:39:22PM +0200, Ville Syrjälä wrote: >> >> If you want the plane to alwa

Re: [PATCH] drm/vc4: Ignore alpha on primary plane

2018-03-02 Thread Ville Syrjälä
On Fri, Mar 02, 2018 at 04:06:58PM +0100, Stefan Schake wrote: > Hey Ville, > > On Fri, Mar 2, 2018 at 3:43 PM, Ville Syrjälä > wrote: > > On Fri, Mar 02, 2018 at 04:39:22PM +0200, Ville Syrjälä wrote: > >> If you want the plane to always be opaque you shouldn't expose any > >> formats with alpha

Re: [PATCH] drm/vc4: Ignore alpha on primary plane

2018-03-02 Thread Stefan Schake
Hey Ville, On Fri, Mar 2, 2018 at 3:43 PM, Ville Syrjälä wrote: > On Fri, Mar 02, 2018 at 04:39:22PM +0200, Ville Syrjälä wrote: >> If you want the plane to always be opaque you shouldn't expose any >> formats with alpha. >> >> Also what happens if one disables the primary plane? Or does the driv

Re: [PATCH] drm/vc4: Ignore alpha on primary plane

2018-03-02 Thread Ville Syrjälä
On Fri, Mar 02, 2018 at 04:39:22PM +0200, Ville Syrjälä wrote: > On Fri, Mar 02, 2018 at 01:32:40AM +0100, Stefan Schake wrote: > > We allow alpha formats on the primary plane but a partially transparent > > framebuffer will cause a corrupted display. With this change black pixels > > are output in

Re: [PATCH] drm/vc4: Ignore alpha on primary plane

2018-03-02 Thread Ville Syrjälä
On Fri, Mar 02, 2018 at 01:32:40AM +0100, Stefan Schake wrote: > We allow alpha formats on the primary plane but a partially transparent > framebuffer will cause a corrupted display. With this change black pixels > are output instead, in line with the behavior for other DRM drivers. > > Signed-off

[PATCH] drm/vc4: Ignore alpha on primary plane

2018-03-01 Thread Stefan Schake
We allow alpha formats on the primary plane but a partially transparent framebuffer will cause a corrupted display. With this change black pixels are output instead, in line with the behavior for other DRM drivers. Signed-off-by: Stefan Schake --- Test program is available at https://github.com/s