Re: [PATCH] drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage

2017-12-08 Thread Stefan Wahren
Hi Daniel, Am 24.11.2017 um 15:52 schrieb Daniel Vetter: On Thu, Nov 23, 2017 at 09:24:11AM +0100, Boris Brezillon wrote: On Wed, 22 Nov 2017 16:13:31 -0800 Eric Anholt wrote: Boris Brezillon writes: On Wed, 22 Nov 2017 13:16:08 -0800 Eric Anholt wrote: Boris Brezillon writes:

Re: [PATCH] drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage

2017-12-07 Thread Boris Brezillon
On Thu, 7 Dec 2017 13:31:34 +0100 Stefan Wahren wrote: > Hi Daniel, > > > Am 24.11.2017 um 15:52 schrieb Daniel Vetter: > > On Thu, Nov 23, 2017 at 09:24:11AM +0100, Boris Brezillon wrote: > >> On Wed, 22 Nov 2017 16:13:31 -0800 > >> Eric Anholt wrote: > >> > >>> Boris Brezillon writes: >

Re: [PATCH] drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage

2017-11-24 Thread Daniel Vetter
On Thu, Nov 23, 2017 at 09:24:11AM +0100, Boris Brezillon wrote: > On Wed, 22 Nov 2017 16:13:31 -0800 > Eric Anholt wrote: > > > Boris Brezillon writes: > > > > > On Wed, 22 Nov 2017 13:16:08 -0800 > > > Eric Anholt wrote: > > > > > >> Boris Brezillon writes: > > >> > > >> > With CONFIG_

Re: [PATCH] drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage

2017-11-23 Thread Boris Brezillon
On Wed, 22 Nov 2017 16:13:31 -0800 Eric Anholt wrote: > Boris Brezillon writes: > > > On Wed, 22 Nov 2017 13:16:08 -0800 > > Eric Anholt wrote: > > > >> Boris Brezillon writes: > >> > >> > With CONFIG_REFCOUNT_FULL enabled, refcount_inc() complains when it's > >> > passed a refcount obje

Re: [PATCH] drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage

2017-11-22 Thread Eric Anholt
Boris Brezillon writes: > On Wed, 22 Nov 2017 13:16:08 -0800 > Eric Anholt wrote: > >> Boris Brezillon writes: >> >> > With CONFIG_REFCOUNT_FULL enabled, refcount_inc() complains when it's >> > passed a refcount object that has its counter set to 0. In this driver, >> > this is a valid use cas

Re: [PATCH] drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage

2017-11-22 Thread Boris Brezillon
On Wed, 22 Nov 2017 13:16:08 -0800 Eric Anholt wrote: > Boris Brezillon writes: > > > With CONFIG_REFCOUNT_FULL enabled, refcount_inc() complains when it's > > passed a refcount object that has its counter set to 0. In this driver, > > this is a valid use case since we want to increment ->usecn

Re: [PATCH] drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage

2017-11-22 Thread Eric Anholt
Boris Brezillon writes: > With CONFIG_REFCOUNT_FULL enabled, refcount_inc() complains when it's > passed a refcount object that has its counter set to 0. In this driver, > this is a valid use case since we want to increment ->usecnt only when > the BO object starts to be used by real HW component

[PATCH] drm/vc4: Fix false positive WARN() backtrace on refcount_inc() usage

2017-11-22 Thread Boris Brezillon
With CONFIG_REFCOUNT_FULL enabled, refcount_inc() complains when it's passed a refcount object that has its counter set to 0. In this driver, this is a valid use case since we want to increment ->usecnt only when the BO object starts to be used by real HW components and this is definitely not the c