Re: [PATCH] drm/vc4: Fix NULL pointer dereference in vc4_save_hang_state()

2018-01-18 Thread Daniel Vetter
On Wed, Jan 17, 2018 at 12:03:15PM -0800, Eric Anholt wrote: > Boris Brezillon writes: > > > When saving BOs in the hang state we skip one entry of the > > kernel_state->bo[] array, thus leaving it to NULL. This leads to a NULL > > pointer dereference when, later in this function, we iterate over

Re: [PATCH] drm/vc4: Fix NULL pointer dereference in vc4_save_hang_state()

2018-01-18 Thread Boris Brezillon
On Wed, 17 Jan 2018 12:03:15 -0800 Eric Anholt wrote: > Boris Brezillon writes: > > > When saving BOs in the hang state we skip one entry of the > > kernel_state->bo[] array, thus leaving it to NULL. This leads to a NULL > > pointer dereference when, later in this function, we iterate over all

Re: [PATCH] drm/vc4: Fix NULL pointer dereference in vc4_save_hang_state()

2018-01-18 Thread Eric Anholt
Boris Brezillon writes: > When saving BOs in the hang state we skip one entry of the > kernel_state->bo[] array, thus leaving it to NULL. This leads to a NULL > pointer dereference when, later in this function, we iterate over all > BOs to check their ->madv state. > > Fixes: ca26d28bbaa3 ("drm/v

[PATCH] drm/vc4: Fix NULL pointer dereference in vc4_save_hang_state()

2018-01-10 Thread Boris Brezillon
When saving BOs in the hang state we skip one entry of the kernel_state->bo[] array, thus leaving it to NULL. This leads to a NULL pointer dereference when, later in this function, we iterate over all BOs to check their ->madv state. Fixes: ca26d28bbaa3 ("drm/vc4: improve throughput by pipelining