Re: [PATCH] drm/vc4: Convert register accessors to FIELD_*

2020-07-08 Thread Maxime Ripard
On Fri, Jul 03, 2020 at 09:57:04AM -0700, Eric Anholt wrote: > On Fri, Jul 3, 2020 at 6:57 AM Maxime Ripard wrote: > > > > The VC4_SET_FIELD and VC4_GET_FIELD are reimplementing most of the logic > > already defined in FIELD_SET and FIELD_GET. Let's convert the vc4 macros to > > use the FIELD_* ma

[PATCH] drm/vc4: Convert register accessors to FIELD_*

2020-07-06 Thread Maxime Ripard
The VC4_SET_FIELD and VC4_GET_FIELD are reimplementing most of the logic already defined in FIELD_SET and FIELD_GET. Let's convert the vc4 macros to use the FIELD_* macros. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_regs.h | 9 - 1 file changed, 4 insertions(+), 5 deletions

Re: [PATCH] drm/vc4: Convert register accessors to FIELD_*

2020-07-03 Thread Eric Anholt
On Fri, Jul 3, 2020 at 6:57 AM Maxime Ripard wrote: > > The VC4_SET_FIELD and VC4_GET_FIELD are reimplementing most of the logic > already defined in FIELD_SET and FIELD_GET. Let's convert the vc4 macros to > use the FIELD_* macros. > > Signed-off-by: Maxime Ripard > --- Reviewed-by: Eric Anholt