Re: [PATCH] drm/vc4: Add runtime PM support to the HDMI encoder driver

2017-04-18 Thread Eric Anholt
Boris Brezillon writes: > On Fri, 14 Apr 2017 11:20:52 -0700 > Eric Anholt wrote: > >> Boris Brezillon writes: >> >> > The HDMI driver is currently enabling all clks and probe time and keep >> > the power-domain connected to the HDMI encoder enabled. >> >> How about "The HDMI driver is curr

Re: [PATCH] drm/vc4: Add runtime PM support to the HDMI encoder driver

2017-04-14 Thread Boris Brezillon
On Fri, 14 Apr 2017 11:20:52 -0700 Eric Anholt wrote: > Boris Brezillon writes: > > > The HDMI driver is currently enabling all clks and probe time and keep > > the power-domain connected to the HDMI encoder enabled. > > How about "The HDMI driver is currently enabling all clocks at probe >

Re: [PATCH] drm/vc4: Add runtime PM support to the HDMI encoder driver

2017-04-14 Thread Eric Anholt
Boris Brezillon writes: > The HDMI driver is currently enabling all clks and probe time and keep > the power-domain connected to the HDMI encoder enabled. How about "The HDMI driver is currently enabling all clocks at probe time and keeps the power domain..."? > Move all activation code to vc4_

[PATCH] drm/vc4: Add runtime PM support to the HDMI encoder driver

2017-04-11 Thread Boris Brezillon
The HDMI driver is currently enabling all clks and probe time and keep the power-domain connected to the HDMI encoder enabled. Move all activation code to vc4_hdmi_encoder_enable() and make sure the clks and power domain are released when the HDMI encoder is not used by adding deactivation steps i