Re: [PATCH] drm/vboxvideo: fix a NULL vs IS_ERR() check

2021-11-18 Thread Hans de Goede
Hi, On 11/18/21 12:12, Dan Carpenter wrote: > The devm_gen_pool_create() function never returns NULL, it returns > error pointers. > > Fixes: 4cc9b565454b ("drm/vboxvideo: Use devm_gen_pool_create") > Signed-off-by: Dan Carpenter Thanks, patch looks good to me: Reviewed-by: Hans de Goede I w

[PATCH] drm/vboxvideo: fix a NULL vs IS_ERR() check

2021-11-18 Thread Dan Carpenter
The devm_gen_pool_create() function never returns NULL, it returns error pointers. Fixes: 4cc9b565454b ("drm/vboxvideo: Use devm_gen_pool_create") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/vboxvideo/vbox_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

Re: [PATCH] drm/vboxvideo: Fix a NULL vs IS_ERR() check in vbox_hw_init()

2020-05-01 Thread Markus Elfring
> The devm_gen_pool_create() function returns ERR_PTR() on error, it > doesn't return NULL so this check doesn't work. How do you think about a wording variant like the following? Change description: A null pointer check was performed after a call of the function “devm_gen_pool_create” d