Re: [PATCH] drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb

2021-02-08 Thread Thomas Zimmermann
Hi Hans Am 03.02.21 um 12:50 schrieb Hans de Goede: If I understand things correctly, there is some memory corruption introduced by this patch, so there will be a v2 fixing this ? The reason why I'm asking is because I always try to test vboxvideo patches inside a vbox vm, but if a v2 is coming

Re: [PATCH] drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb

2021-02-03 Thread Thomas Zimmermann
Hi Am 03.02.21 um 12:50 schrieb Hans de Goede: Hi, On 2/3/21 12:14 PM, Thomas Zimmermann wrote: Hi Am 03.02.21 um 11:44 schrieb Daniel Vetter: On Wed, Feb 03, 2021 at 11:34:21AM +0100, Thomas Zimmermann wrote: Hi Am 03.02.21 um 11:29 schrieb Daniel Vetter: On Wed, Jan 27, 2021 at 03:05:03

Re: [PATCH] drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb

2021-02-03 Thread Hans de Goede
Hi, On 2/3/21 12:14 PM, Thomas Zimmermann wrote: > Hi > > Am 03.02.21 um 11:44 schrieb Daniel Vetter: >> On Wed, Feb 03, 2021 at 11:34:21AM +0100, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 03.02.21 um 11:29 schrieb Daniel Vetter: On Wed, Jan 27, 2021 at 03:05:03PM +0100, Thomas Zimmermann w

Re: [PATCH] drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb

2021-02-03 Thread Thomas Zimmermann
Hi Am 03.02.21 um 11:44 schrieb Daniel Vetter: On Wed, Feb 03, 2021 at 11:34:21AM +0100, Thomas Zimmermann wrote: Hi Am 03.02.21 um 11:29 schrieb Daniel Vetter: On Wed, Jan 27, 2021 at 03:05:03PM +0100, Thomas Zimmermann wrote: Functions in the atomic commit tail are not allowed to acquire t

Re: [PATCH] drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb

2021-02-03 Thread Daniel Vetter
On Wed, Feb 03, 2021 at 11:34:21AM +0100, Thomas Zimmermann wrote: > Hi > > Am 03.02.21 um 11:29 schrieb Daniel Vetter: > > On Wed, Jan 27, 2021 at 03:05:03PM +0100, Thomas Zimmermann wrote: > > > Functions in the atomic commit tail are not allowed to acquire the > > > dmabuf's reservation lock. S

Re: [PATCH] drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb

2021-02-03 Thread Thomas Zimmermann
Hi Am 03.02.21 um 11:29 schrieb Daniel Vetter: On Wed, Jan 27, 2021 at 03:05:03PM +0100, Thomas Zimmermann wrote: Functions in the atomic commit tail are not allowed to acquire the dmabuf's reservation lock. So we cannot legally call the GEM object's vmap functionality in atomic_update. Instea

Re: [PATCH] drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb

2021-02-03 Thread Daniel Vetter
On Wed, Jan 27, 2021 at 03:05:03PM +0100, Thomas Zimmermann wrote: > Functions in the atomic commit tail are not allowed to acquire the > dmabuf's reservation lock. So we cannot legally call the GEM object's > vmap functionality in atomic_update. > > Instead vmap the cursor BO in prepare_fb and vu

[PATCH] drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb

2021-01-27 Thread Thomas Zimmermann
Functions in the atomic commit tail are not allowed to acquire the dmabuf's reservation lock. So we cannot legally call the GEM object's vmap functionality in atomic_update. Instead vmap the cursor BO in prepare_fb and vunmap it in cleanup_fb. The cursor plane state stores the mapping's address. T