Re: [PATCH] drm/vboxvideo: Unmap iomem on probe-failure and remove

2020-11-20 Thread Daniel Vetter
On Fri, Nov 20, 2020 at 02:00:55PM +0300, Dan Carpenter wrote: > On Fri, Nov 20, 2020 at 10:39:45AM +0100, Daniel Vetter wrote: > > On Fri, Nov 20, 2020 at 8:58 AM Dan Carpenter > > wrote: > > > > > > On Thu, Nov 19, 2020 at 08:30:59PM +0100, Daniel Vetter wrote: > > > > On Thu, Nov 19, 2020 at 6

Re: [PATCH] drm/vboxvideo: Unmap iomem on probe-failure and remove

2020-11-20 Thread Dan Carpenter
On Fri, Nov 20, 2020 at 10:39:45AM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2020 at 8:58 AM Dan Carpenter > wrote: > > > > On Thu, Nov 19, 2020 at 08:30:59PM +0100, Daniel Vetter wrote: > > > On Thu, Nov 19, 2020 at 6:51 PM Dan Carpenter > > > wrote: > > > > > > > > On Thu, Nov 19, 2020 at

Re: [PATCH] drm/vboxvideo: Unmap iomem on probe-failure and remove

2020-11-20 Thread Daniel Vetter
On Fri, Nov 20, 2020 at 8:58 AM Dan Carpenter wrote: > > On Thu, Nov 19, 2020 at 08:30:59PM +0100, Daniel Vetter wrote: > > On Thu, Nov 19, 2020 at 6:51 PM Dan Carpenter > > wrote: > > > > > > On Thu, Nov 19, 2020 at 12:35:56PM +0100, Hans de Goede wrote: > > > > Hi, > > > > > > > > On 10/27/20

Re: [PATCH] drm/vboxvideo: Unmap iomem on probe-failure and remove

2020-11-19 Thread Dan Carpenter
On Thu, Nov 19, 2020 at 08:30:59PM +0100, Daniel Vetter wrote: > On Thu, Nov 19, 2020 at 6:51 PM Dan Carpenter > wrote: > > > > On Thu, Nov 19, 2020 at 12:35:56PM +0100, Hans de Goede wrote: > > > Hi, > > > > > > On 10/27/20 2:51 PM, Hans de Goede wrote: > > > > Add missing pci_iounmap() calls to

Re: [PATCH] drm/vboxvideo: Unmap iomem on probe-failure and remove

2020-11-19 Thread Daniel Vetter
On Thu, Nov 19, 2020 at 6:51 PM Dan Carpenter wrote: > > On Thu, Nov 19, 2020 at 12:35:56PM +0100, Hans de Goede wrote: > > Hi, > > > > On 10/27/20 2:51 PM, Hans de Goede wrote: > > > Add missing pci_iounmap() calls to properly unmap the memory on > > > probe-failure and remove. > > > > > > Report

Re: [PATCH] drm/vboxvideo: Unmap iomem on probe-failure and remove

2020-11-19 Thread Dan Carpenter
On Thu, Nov 19, 2020 at 12:35:56PM +0100, Hans de Goede wrote: > Hi, > > On 10/27/20 2:51 PM, Hans de Goede wrote: > > Add missing pci_iounmap() calls to properly unmap the memory on > > probe-failure and remove. > > > > Reported-by: kernel test robot > > Reported-by: Dan Carpenter > > Signed-o

Re: [PATCH] drm/vboxvideo: Unmap iomem on probe-failure and remove

2020-11-19 Thread Hans de Goede
Hi, On 10/27/20 2:51 PM, Hans de Goede wrote: > Add missing pci_iounmap() calls to properly unmap the memory on > probe-failure and remove. > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Hans de Goede For some reason the spam-filter used by Red Hat's email sy

Re: [PATCH] drm/vboxvideo: Unmap iomem on probe-failure and remove

2020-10-27 Thread Daniel Vetter
On Tue, Oct 27, 2020 at 2:52 PM Hans de Goede wrote: > > Add missing pci_iounmap() calls to properly unmap the memory on > probe-failure and remove. > > Reported-by: kernel test robot > Reported-by: Dan Carpenter > Signed-off-by: Hans de Goede I think switching over to devm would be really nic

[PATCH] drm/vboxvideo: Unmap iomem on probe-failure and remove

2020-10-27 Thread Hans de Goede
Add missing pci_iounmap() calls to properly unmap the memory on probe-failure and remove. Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Hans de Goede --- drivers/gpu/drm/vboxvideo/vbox_main.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions