[PATCH] drm/vblank: WARN_ON nested use of drm_vblank_on/off

2015-06-26 Thread Tomeu Vizoso
On 22 June 2015 at 14:02, Daniel Vetter wrote: > We should never nest these since in theory kms drivers should know > when a pipe is on/off and call the corresponding enable/disable > functions for the vblank helper code only once. But for historical > reasons (the shared-with-ums version of this

[Intel-gfx] [PATCH] drm/vblank: WARN_ON nested use of drm_vblank_on/off

2015-06-22 Thread Jani Nikula
On Mon, 22 Jun 2015, Josh Boyer wrote: > On Mon, Jun 22, 2015 at 9:27 AM, Jani Nikula > wrote: >> On Mon, 22 Jun 2015, Josh Boyer wrote: >>> On Mon, Jun 22, 2015 at 8:02 AM, Daniel Vetter >>> wrote: We should never nest these since in theory kms drivers should know when a pipe is on/

[Intel-gfx] [PATCH] drm/vblank: WARN_ON nested use of drm_vblank_on/off

2015-06-22 Thread Jani Nikula
On Mon, 22 Jun 2015, Josh Boyer wrote: > On Mon, Jun 22, 2015 at 8:02 AM, Daniel Vetter > wrote: >> We should never nest these since in theory kms drivers should know >> when a pipe is on/off and call the corresponding enable/disable >> functions for the vblank helper code only once. But for his

[PATCH] drm/vblank: WARN_ON nested use of drm_vblank_on/off

2015-06-22 Thread Daniel Vetter
We should never nest these since in theory kms drivers should know when a pipe is on/off and call the corresponding enable/disable functions for the vblank helper code only once. But for historical reasons (the shared-with-ums version of this code in modeset_pre/post needed to be able to cope with

[Intel-gfx] [PATCH] drm/vblank: WARN_ON nested use of drm_vblank_on/off

2015-06-22 Thread Josh Boyer
On Mon, Jun 22, 2015 at 9:27 AM, Jani Nikula wrote: > On Mon, 22 Jun 2015, Josh Boyer wrote: >> On Mon, Jun 22, 2015 at 8:02 AM, Daniel Vetter >> wrote: >>> We should never nest these since in theory kms drivers should know >>> when a pipe is on/off and call the corresponding enable/disable >>>

[Intel-gfx] [PATCH] drm/vblank: WARN_ON nested use of drm_vblank_on/off

2015-06-22 Thread Josh Boyer
On Mon, Jun 22, 2015 at 8:02 AM, Daniel Vetter wrote: > We should never nest these since in theory kms drivers should know > when a pipe is on/off and call the corresponding enable/disable > functions for the vblank helper code only once. But for historical > reasons (the shared-with-ums version