Re: [PATCH] drm/v3d: Fix perfmon build error/warning

2024-06-07 Thread Tvrtko Ursulin
On 05/06/2024 08:19, Iago Toral wrote: Thanks for looking at ixing this Tvrtko. El mar, 04-06-2024 a las 17:02 +0100, Tvrtko Ursulin escribió: From: Tvrtko Ursulin Move static const array into the source file to fix the "defined but not used" errors. The fix is perhaps not the prettiest du

Re: [PATCH] drm/v3d: Fix perfmon build error/warning

2024-06-05 Thread Jani Nikula
On Tue, 04 Jun 2024, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Move static const array into the source file to fix the "defined but not > used" errors. > > The fix is perhaps not the prettiest due hand crafting the array sizes > in v3d_performance_counters.h, but I did add some build time

Re: (subset) [PATCH] drm/v3d: Fix perfmon build error/warning

2024-06-05 Thread Maxime Ripard
On Tue, 04 Jun 2024 17:02:10 +0100, Tvrtko Ursulin wrote: > Move static const array into the source file to fix the "defined but not > used" errors. > > The fix is perhaps not the prettiest due hand crafting the array sizes > in v3d_performance_counters.h, but I did add some build time asserts to

Re: [PATCH] drm/v3d: Fix perfmon build error/warning

2024-06-05 Thread Maxime Ripard
Hi, On Wed, Jun 05, 2024 at 08:19:34AM GMT, Iago Toral wrote: > Thanks for looking at ixing this Tvrtko. > > El mar, 04-06-2024 a las 17:02 +0100, Tvrtko Ursulin escribió: > > From: Tvrtko Ursulin > > > > Move static const array into the source file to fix the "defined but > > not > > used" err

Re: [PATCH] drm/v3d: Fix perfmon build error/warning

2024-06-04 Thread Iago Toral
Thanks for looking at ixing this Tvrtko. El mar, 04-06-2024 a las 17:02 +0100, Tvrtko Ursulin escribió: > From: Tvrtko Ursulin > > Move static const array into the source file to fix the "defined but > not > used" errors. > > The fix is perhaps not the prettiest due hand crafting the array > si

[PATCH] drm/v3d: Fix perfmon build error/warning

2024-06-04 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Move static const array into the source file to fix the "defined but not used" errors. The fix is perhaps not the prettiest due hand crafting the array sizes in v3d_performance_counters.h, but I did add some build time asserts to validate the counts look sensible, so hopeful