Re: [PATCH] drm/v3d: Fix null pointer dereference of pointer perfmon

2022-04-26 Thread Melissa Wen
On 04/25, Juan A. Suárez wrote: > On Sun, 2022-04-24 at 19:35 +0100, Colin Ian King wrote: > > In the unlikely event that pointer perfmon is null the WARN_ON return > > path > > occurs after the pointer has already been deferenced. Fix this by > > only > > dereferencing perfmon after it has been nu

Re: [PATCH] drm/v3d: Fix null pointer dereference of pointer perfmon

2022-04-25 Thread Juan A.
On Sun, 2022-04-24 at 19:35 +0100, Colin Ian King wrote: > In the unlikely event that pointer perfmon is null the WARN_ON return > path > occurs after the pointer has already been deferenced. Fix this by > only > dereferencing perfmon after it has been null checked. > Good catch! Reviewed-by: Ju

[PATCH] drm/v3d: Fix null pointer dereference of pointer perfmon

2022-04-24 Thread Colin Ian King
In the unlikely event that pointer perfmon is null the WARN_ON return path occurs after the pointer has already been deferenced. Fix this by only dereferencing perfmon after it has been null checked. Fixes: 26a4dc29b74a ("drm/v3d: Expose performance counters to userspace") Signed-off-by: Colin Ian