[PATCH] drm/ttm: remove fence_lock

2014-03-25 Thread Maarten Lankhorst
Hey, op 21-03-14 14:04, Thomas Hellstrom schreef: > On 03/21/2014 01:12 PM, Maarten Lankhorst wrote: >> Hey, >> >> op 21-03-14 09:27, Thomas Hellstrom schreef: >>> On 03/21/2014 12:55 AM, Dave Airlie wrote: On Fri, Oct 19, 2012 at 3:04 AM, Jerome Glisse wrote: > On Thu, Oct 18, 2012

[PATCH] drm/ttm: remove fence_lock

2014-03-21 Thread Thomas Hellstrom
On 03/21/2014 01:12 PM, Maarten Lankhorst wrote: > Hey, > > op 21-03-14 09:27, Thomas Hellstrom schreef: >> On 03/21/2014 12:55 AM, Dave Airlie wrote: >>> On Fri, Oct 19, 2012 at 3:04 AM, Jerome Glisse >>> wrote: On Thu, Oct 18, 2012 at 06:43:40PM +0200, Thomas Hellstrom wrote: > On 10/18

[PATCH] drm/ttm: remove fence_lock

2014-03-21 Thread Maarten Lankhorst
Hey, op 21-03-14 09:27, Thomas Hellstrom schreef: > On 03/21/2014 12:55 AM, Dave Airlie wrote: >> On Fri, Oct 19, 2012 at 3:04 AM, Jerome Glisse wrote: >>> On Thu, Oct 18, 2012 at 06:43:40PM +0200, Thomas Hellstrom wrote: On 10/18/2012 04:45 PM, Maarten Lankhorst wrote: > Op 18-10-12 13:

[PATCH] drm/ttm: remove fence_lock

2014-03-21 Thread Dave Airlie
On Fri, Oct 19, 2012 at 3:04 AM, Jerome Glisse wrote: > On Thu, Oct 18, 2012 at 06:43:40PM +0200, Thomas Hellstrom wrote: >> On 10/18/2012 04:45 PM, Maarten Lankhorst wrote: >> >Op 18-10-12 13:55, Thomas Hellstrom schreef: >> >>On 10/18/2012 01:38 PM, Maarten Lankhorst wrote: >> >>>Op 18-10-12 13:

[PATCH] drm/ttm: remove fence_lock

2014-03-21 Thread Thomas Hellstrom
On 03/21/2014 12:55 AM, Dave Airlie wrote: > On Fri, Oct 19, 2012 at 3:04 AM, Jerome Glisse wrote: >> On Thu, Oct 18, 2012 at 06:43:40PM +0200, Thomas Hellstrom wrote: >>> On 10/18/2012 04:45 PM, Maarten Lankhorst wrote: Op 18-10-12 13:55, Thomas Hellstrom schreef: > On 10/18/2012 01:38 P

[PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Thomas Hellstrom
On 10/18/2012 04:45 PM, Maarten Lankhorst wrote: > Op 18-10-12 13:55, Thomas Hellstrom schreef: >> On 10/18/2012 01:38 PM, Maarten Lankhorst wrote: >>> Op 18-10-12 13:02, Thomas Hellstrom schreef: On 10/18/2012 10:37 AM, Maarten Lankhorst wrote: > Hey, > > Op 18-10-12 09:59, Thomas

[PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Maarten Lankhorst
Op 18-10-12 13:55, Thomas Hellstrom schreef: > On 10/18/2012 01:38 PM, Maarten Lankhorst wrote: >> Op 18-10-12 13:02, Thomas Hellstrom schreef: >>> On 10/18/2012 10:37 AM, Maarten Lankhorst wrote: Hey, Op 18-10-12 09:59, Thomas Hellstrom schreef: > > On 10/18/2012 09:28 AM, T

[PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Thomas Hellstrom
On 10/18/2012 01:38 PM, Maarten Lankhorst wrote: > Op 18-10-12 13:02, Thomas Hellstrom schreef: >> On 10/18/2012 10:37 AM, Maarten Lankhorst wrote: >>> Hey, >>> >>> Op 18-10-12 09:59, Thomas Hellstrom schreef: On 10/18/2012 09:28 AM, Thomas Hellstrom wrote: > Hi, Maarten, > >

[PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Maarten Lankhorst
Op 18-10-12 13:02, Thomas Hellstrom schreef: > On 10/18/2012 10:37 AM, Maarten Lankhorst wrote: >> Hey, >> >> Op 18-10-12 09:59, Thomas Hellstrom schreef: >>> >>> >>> On 10/18/2012 09:28 AM, Thomas Hellstrom wrote: Hi, Maarten, As you know I have been having my doubts about this chan

[PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Jerome Glisse
On Thu, Oct 18, 2012 at 06:43:40PM +0200, Thomas Hellstrom wrote: > On 10/18/2012 04:45 PM, Maarten Lankhorst wrote: > >Op 18-10-12 13:55, Thomas Hellstrom schreef: > >>On 10/18/2012 01:38 PM, Maarten Lankhorst wrote: > >>>Op 18-10-12 13:02, Thomas Hellstrom schreef: > On 10/18/2012 10:37 AM, M

[PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Thomas Hellstrom
On 10/18/2012 10:37 AM, Maarten Lankhorst wrote: > Hey, > > Op 18-10-12 09:59, Thomas Hellstrom schreef: >> >> >> On 10/18/2012 09:28 AM, Thomas Hellstrom wrote: >>> Hi, Maarten, >>> >>> As you know I have been having my doubts about this change. >>> To me it seems insane to be forced to read the f

[PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Maarten Lankhorst
Hey, Op 18-10-12 09:59, Thomas Hellstrom schreef: > > > > On 10/18/2012 09:28 AM, Thomas Hellstrom wrote: >> Hi, Maarten, >> >> As you know I have been having my doubts about this change. >> To me it seems insane to be forced to read the fence pointer under a >> reserved lock, simply because when

Re: [PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Jerome Glisse
On Thu, Oct 18, 2012 at 06:43:40PM +0200, Thomas Hellstrom wrote: > On 10/18/2012 04:45 PM, Maarten Lankhorst wrote: > >Op 18-10-12 13:55, Thomas Hellstrom schreef: > >>On 10/18/2012 01:38 PM, Maarten Lankhorst wrote: > >>>Op 18-10-12 13:02, Thomas Hellstrom schreef: > On 10/18/2012 10:37 AM, M

[PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Thomas Hellstrom
On 10/18/2012 09:28 AM, Thomas Hellstrom wrote: > Hi, Maarten, > > As you know I have been having my doubts about this change. > To me it seems insane to be forced to read the fence pointer under a > reserved lock, simply because when you take the reserve lock, another > process may have it and

Re: [PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Thomas Hellstrom
On 10/18/2012 04:45 PM, Maarten Lankhorst wrote: Op 18-10-12 13:55, Thomas Hellstrom schreef: On 10/18/2012 01:38 PM, Maarten Lankhorst wrote: Op 18-10-12 13:02, Thomas Hellstrom schreef: On 10/18/2012 10:37 AM, Maarten Lankhorst wrote: Hey, Op 18-10-12 09:59, Thomas Hellstrom schreef: On 1

[PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Thomas Hellstrom
Hi, Maarten, As you know I have been having my doubts about this change. To me it seems insane to be forced to read the fence pointer under a reserved lock, simply because when you take the reserve lock, another process may have it and there is a substantial chance that that process will also be w

Re: [PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Maarten Lankhorst
Op 18-10-12 13:55, Thomas Hellstrom schreef: > On 10/18/2012 01:38 PM, Maarten Lankhorst wrote: >> Op 18-10-12 13:02, Thomas Hellstrom schreef: >>> On 10/18/2012 10:37 AM, Maarten Lankhorst wrote: Hey, Op 18-10-12 09:59, Thomas Hellstrom schreef: > > On 10/18/2012 09:28 AM, T

Re: [PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Thomas Hellstrom
On 10/18/2012 01:38 PM, Maarten Lankhorst wrote: Op 18-10-12 13:02, Thomas Hellstrom schreef: On 10/18/2012 10:37 AM, Maarten Lankhorst wrote: Hey, Op 18-10-12 09:59, Thomas Hellstrom schreef: On 10/18/2012 09:28 AM, Thomas Hellstrom wrote: Hi, Maarten, As you know I have been having my do

Re: [PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Maarten Lankhorst
Op 18-10-12 13:02, Thomas Hellstrom schreef: > On 10/18/2012 10:37 AM, Maarten Lankhorst wrote: >> Hey, >> >> Op 18-10-12 09:59, Thomas Hellstrom schreef: >>> >>> >>> On 10/18/2012 09:28 AM, Thomas Hellstrom wrote: Hi, Maarten, As you know I have been having my doubts about this chan

Re: [PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Thomas Hellstrom
On 10/18/2012 10:37 AM, Maarten Lankhorst wrote: Hey, Op 18-10-12 09:59, Thomas Hellstrom schreef: On 10/18/2012 09:28 AM, Thomas Hellstrom wrote: Hi, Maarten, As you know I have been having my doubts about this change. To me it seems insane to be forced to read the fence pointer under a re

Re: [PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Maarten Lankhorst
Hey, Op 18-10-12 09:59, Thomas Hellstrom schreef: > > > > On 10/18/2012 09:28 AM, Thomas Hellstrom wrote: >> Hi, Maarten, >> >> As you know I have been having my doubts about this change. >> To me it seems insane to be forced to read the fence pointer under a >> reserved lock, simply because when

Re: [PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Thomas Hellstrom
On 10/18/2012 09:28 AM, Thomas Hellstrom wrote: Hi, Maarten, As you know I have been having my doubts about this change. To me it seems insane to be forced to read the fence pointer under a reserved lock, simply because when you take the reserve lock, another process may have it and there is

Re: [PATCH] drm/ttm: remove fence_lock

2012-10-18 Thread Thomas Hellstrom
Hi, Maarten, As you know I have been having my doubts about this change. To me it seems insane to be forced to read the fence pointer under a reserved lock, simply because when you take the reserve lock, another process may have it and there is a substantial chance that that process will also be

[PATCH] drm/ttm: remove fence_lock

2012-10-12 Thread Maarten Lankhorst
With the nouveau calls fixed there were only 2 places left that used fence_lock without a reservation, those are fixed in this patch: ttm_bo_cleanup_refs_or_queue is fixed by simply doing things the other way around. ttm_bo_cleanup_refs is fixed by taking a reservation first, then a pointer to th

[PATCH] drm/ttm: remove fence_lock

2012-10-12 Thread Maarten Lankhorst
With the nouveau calls fixed there were only 2 places left that used fence_lock without a reservation, those are fixed in this patch: ttm_bo_cleanup_refs_or_queue is fixed by simply doing things the other way around. ttm_bo_cleanup_refs is fixed by taking a reservation first, then a pointer to th