Re: [PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings v2

2021-06-07 Thread Christian König
Am 07.06.21 um 18:13 schrieb Thomas Hellström (Intel): On 6/7/21 3:58 PM, Christian König wrote: We discussed if that is really the right approach for quite a while now, but digging deeper into a bug report on arm turned out that this is actually horrible broken right now. The reason for t

Re: [PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings v2

2021-06-07 Thread Intel
On 6/7/21 3:58 PM, Christian König wrote: We discussed if that is really the right approach for quite a while now, but digging deeper into a bug report on arm turned out that this is actually horrible broken right now. The reason for this is that vmf_insert_mixed_prot() always tries to grab a

[PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings v2

2021-06-07 Thread Christian König
We discussed if that is really the right approach for quite a while now, but digging deeper into a bug report on arm turned out that this is actually horrible broken right now. The reason for this is that vmf_insert_mixed_prot() always tries to grab a reference to the underlaying page on architect

Re: [PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings

2021-06-02 Thread Intel
On 6/2/21 8:36 PM, Daniel Vetter wrote: On Wed, Jun 02, 2021 at 02:21:17PM +0200, Thomas Hellström wrote: On 6/2/21 2:04 PM, Christian König wrote: Am 02.06.21 um 13:24 schrieb Thomas Hellström (Intel): [SNIP] @@ -576,14 +565,10 @@ static void ttm_bo_mmap_vma_setup(struct ttm_buffer_object

Re: [PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings

2021-06-02 Thread Christian König
Am 02.06.21 um 20:38 schrieb Daniel Vetter: On Wed, Jun 02, 2021 at 10:30:13AM +0200, Christian König wrote: We discussed if that is really the right approach for quite a while now, but digging deeper into a bug report on arm turned out that this is actually horrible broken right now. The re

Re: [PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings

2021-06-02 Thread Daniel Vetter
On Wed, Jun 02, 2021 at 10:30:13AM +0200, Christian König wrote: > We discussed if that is really the right approach for quite a while now, but > digging deeper into a bug report on arm turned out that this is actually > horrible broken right now. > > The reason for this is that vmf_insert_mixed_p

Re: [PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings

2021-06-02 Thread Daniel Vetter
On Wed, Jun 02, 2021 at 02:21:17PM +0200, Thomas Hellström wrote: > > On 6/2/21 2:04 PM, Christian König wrote: > > > > > > Am 02.06.21 um 13:24 schrieb Thomas Hellström (Intel): > > > [SNIP] > > > > > > @@ -576,14 +565,10 @@ static void > > > > > > ttm_bo_mmap_vma_setup(struct ttm_buffer_object

Re: [PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings

2021-06-02 Thread Thomas Hellström
On 6/2/21 2:04 PM, Christian König wrote: Am 02.06.21 um 13:24 schrieb Thomas Hellström (Intel): [SNIP] @@ -576,14 +565,10 @@ static void ttm_bo_mmap_vma_setup(struct ttm_buffer_object *bo, struct vm_area_s     vma->vm_private_data = bo;   -    /* - * We'd like to use VM_PFNMAP on

Re: [PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings

2021-06-02 Thread Christian König
Am 02.06.21 um 13:24 schrieb Thomas Hellström (Intel): [SNIP] @@ -576,14 +565,10 @@ static void ttm_bo_mmap_vma_setup(struct ttm_buffer_object *bo, struct vm_area_s     vma->vm_private_data = bo;   -    /* - * We'd like to use VM_PFNMAP on shared mappings, where - * (vma->vm_flag

Re: [PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings

2021-06-02 Thread Intel
Hi, On 6/2/21 12:03 PM, Christian König wrote: Am 02.06.21 um 11:07 schrieb Thomas Hellström (Intel): On 6/2/21 10:30 AM, Christian König wrote: We discussed if that is really the right approach for quite a while now, but digging deeper into a bug report on arm turned out that this is actu

Re: [PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings

2021-06-02 Thread Christian König
Am 02.06.21 um 11:07 schrieb Thomas Hellström (Intel): On 6/2/21 10:30 AM, Christian König wrote: We discussed if that is really the right approach for quite a while now, but digging deeper into a bug report on arm turned out that this is actually horrible broken right now. The reason for

Re: [PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings

2021-06-02 Thread Intel
On 6/2/21 10:30 AM, Christian König wrote: We discussed if that is really the right approach for quite a while now, but digging deeper into a bug report on arm turned out that this is actually horrible broken right now. The reason for this is that vmf_insert_mixed_prot() always tries to grab a

[PATCH] drm/ttm: nuke VM_MIXEDMAP on BO mappings

2021-06-02 Thread Christian König
We discussed if that is really the right approach for quite a while now, but digging deeper into a bug report on arm turned out that this is actually horrible broken right now. The reason for this is that vmf_insert_mixed_prot() always tries to grab a reference to the underlaying page on architect