; dri-devel@lists.freedesktop.org
; amd-...@lists.freedesktop.org
*Subject:* Re: [PATCH] drm/ttm: fix ttm tt init fail when size exceeds
kmalloc limit
On 2022-04-20 09:23, Lazar, Lijo wrote:
>
>
> On 4/20/2022 6:26 PM, Christian König wrote:
>> Am 20.04.22 um 14:54 schrieb W
m should allocate 1TB/4k * 8 buffer to
>>>>> store allocate result (page address), this should not be failed
>>>>> usually.
>>>>>
>>>>> There is a similar fix in upstream kernel 5.18, before this fix
>>>>> entered the TTM code, this problem exis
egards,
Kevin
*From:* Koenig, Christian
*Sent:* Wednesday, April 20, 2022 8:42 PM
*To:* Wang, Yang(Kevin) ; Christian König
; dri-devel@lists.freedesktop.org
; amd-...@lists.freedesktop.org
*Subject:* Re: [PATCH] drm/ttm: fix ttm tt init fail when size
exceeds kmal
g
; amd-...@lists.freedesktop.org
*Subject:* Re: [PATCH] drm/ttm: fix ttm tt init fail when size exceeds
kmalloc limit
Hi Kevin,
yes and that is perfectly valid and expected behavior. There is
absolutely no need to change anything in TTM here.
What we could do is:
1) Change the test case to use something larger t
gt;
<mailto:dri-devel@lists.freedesktop.org>;
amd-...@lists.freedesktop.org<mailto:amd-...@lists.freedesktop.org>
<mailto:amd-...@lists.freedesktop.org>
Subject: Re: [PATCH] drm/ttm: fix ttm tt init fail when size exceeds kmalloc
limit
Hi Kevin,
no, the test case should already fail i
) ; Christian König
; dri-devel@lists.freedesktop.org
; amd-...@lists.freedesktop.org
Subject: Re: [PATCH] drm/ttm: fix ttm tt init fail when size exceeds kmalloc
limit
Hi Kevin,
yes and that is perfectly valid and expected behavior. There is absolutely no
need to change anything in TTM here.
What we
; amd-...@lists.freedesktop.org
Subject: Re: [PATCH] drm/ttm: fix ttm tt init fail when size exceeds kmalloc
limit
Hi Kevin,
no, the test case should already fail in amdgpu_bo_validate_size().
If we have a system with 2TiB of memory where the test case could succeed then
we should incr
d-...@lists.freedesktop.org>
<mailto:amd-...@lists.freedesktop.org>
*Subject:* Re: [PATCH] drm/ttm: fix ttm tt init fail when size
exceeds kmalloc limit
Am 20.04.22 um 10:56 schrieb Yang Wang:
> if the __GFP_ZERO is set, the kvmalloc() can't fallback to use
vmalloc()
Hui what? Why should kvmallo
lloc
Best Regards,
Kevin
From: Koenig, Christian
Sent: Wednesday, April 20, 2022 6:53 PM
To: Wang, Yang(Kevin) ; dri-devel@lists.freedesktop.org
; amd-...@lists.freedesktop.org
Subject: Re: [PATCH] drm/ttm: fix ttm tt init fail when size exceeds kmalloc
limit
A
-...@lists.freedesktop.org
*Subject:* Re: [PATCH] drm/ttm: fix ttm tt init fail when size exceeds
kmalloc limit
Am 20.04.22 um 10:56 schrieb Yang Wang:
> if the __GFP_ZERO is set, the kvmalloc() can't fallback to use vmalloc()
Hui what? Why should kvmalloc() not be able to fallback to vmallo
[AMD Official Use Only]
From: Koenig, Christian
Sent: Wednesday, April 20, 2022 5:00 PM
To: Wang, Yang(Kevin) ; dri-devel@lists.freedesktop.org
; amd-...@lists.freedesktop.org
Subject: Re: [PATCH] drm/ttm: fix ttm tt init fail when size exceeds kmalloc
limit
Am 20.04.22 um 10:56 schrieb Yang Wang:
if the __GFP_ZERO is set, the kvmalloc() can't fallback to use vmalloc()
Hui what? Why should kvmalloc() not be able to fallback to vmalloc()
when __GFP_ZERO is set?
And even that is really the case then that sounds like a bug in kvmalloc().
Regards,
if the __GFP_ZERO is set, the kvmalloc() can't fallback to use vmalloc()
to allocate memory, when request size is exceeds kmalloc limit, it will
cause allocate memory fail.
e.g: when ttm want to create a BO with 1TB size, it maybe fail.
Signed-off-by: Yang Wang
---
drivers/gpu/drm/ttm/ttm_tt.c
13 matches
Mail list logo
