Re: [PATCH] drm/ttm: fix pipelined gutting

2021-06-08 Thread kernel test robot
Hi "Christian, I love your patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [also build test ERROR on next-20210608] [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.13-rc5] [If your patch is

Re: [PATCH] drm/ttm: fix pipelined gutting

2021-06-08 Thread kernel test robot
Hi "Christian, I love your patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] [cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.13-rc5 next-20210607] [If your patch is applied to the wrong git t

Re: [PATCH] drm/ttm: fix pipelined gutting v2

2021-06-08 Thread Thomas Hellström
On 6/8/21 10:19 AM, Christian König wrote: We need to make sure to allocate the sys_mem resource before the point of no return. v2: add missing return value checking, also handle idle case Signed-off-by: Christian König lgtm. Reviewed-by: Thomas Hellström

[PATCH] drm/ttm: fix pipelined gutting v2

2021-06-08 Thread Christian König
We need to make sure to allocate the sys_mem resource before the point of no return. v2: add missing return value checking, also handle idle case Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 28 1 file changed, 20 insertions(+), 8 deletions

Re: [PATCH] drm/ttm: fix pipelined gutting

2021-06-08 Thread Thomas Hellström
On 6/8/21 9:50 AM, Christian König wrote: We need to make sure to allocate the sys_mem resource before the point of no return. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/dr

[PATCH] drm/ttm: fix pipelined gutting

2021-06-08 Thread Christian König
We need to make sure to allocate the sys_mem resource before the point of no return. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo_util.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/d

Re: [PATCH] drm/ttm: fix pipelined gutting for evictions v2

2020-07-26 Thread Sierra Guiza, Alejandro (Alex)
On 7/24/2020 10:01 AM, Felix Kuehling wrote: Am 2020-07-24 um 7:56 a.m. schrieb Christian König: We can't pipeline that during eviction because the memory needs to be available immediately. v2: fix how we cleanup the BOs resources Signed-off-by: Christian König Reviewed-by: Felix Kuehling

Re: [PATCH] drm/ttm: fix pipelined gutting for evictions v2

2020-07-24 Thread Felix Kuehling
Am 2020-07-24 um 7:56 a.m. schrieb Christian König: > We can't pipeline that during eviction because the memory needs > to be available immediately. > > v2: fix how we cleanup the BOs resources > > Signed-off-by: Christian König Reviewed-by: Felix Kuehling It would be good to get a Tested-by fr

[PATCH] drm/ttm: fix pipelined gutting for evictions v2

2020-07-24 Thread Christian König
We can't pipeline that during eviction because the memory needs to be available immediately. v2: fix how we cleanup the BOs resources Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/t

Re: [PATCH] drm/ttm: fix pipelined gutting for evictions

2020-07-24 Thread Christian König
Am 24.07.20 um 04:56 schrieb Felix Kuehling: Am 2020-07-23 um 9:58 p.m. schrieb philip yang: On 2020-07-23 7:02 p.m., Felix Kuehling wrote: Am 2020-07-23 um 5:00 a.m. schrieb Christian König: We can't pipeline that during eviction because the memory needs to be available immediately. Signed-o

Re: [PATCH] drm/ttm: fix pipelined gutting for evictions

2020-07-23 Thread Felix Kuehling
Am 2020-07-23 um 9:58 p.m. schrieb philip yang: > > On 2020-07-23 7:02 p.m., Felix Kuehling wrote: >> Am 2020-07-23 um 5:00 a.m. schrieb Christian König: >>> We can't pipeline that during eviction because the memory needs >>> to be available immediately. >>> >>> Signed-off-by: Christian König >>>

Re: [PATCH] drm/ttm: fix pipelined gutting for evictions

2020-07-23 Thread philip yang
On 2020-07-23 7:02 p.m., Felix Kuehling wrote: Am 2020-07-23 um 5:00 a.m. schrieb Christian König: We can't pipeline that during eviction because the memory needs to be available immediately. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 12 ++-- 1 file changed,

Re: [PATCH] drm/ttm: fix pipelined gutting for evictions

2020-07-23 Thread Felix Kuehling
Am 2020-07-23 um 5:00 a.m. schrieb Christian König: > We can't pipeline that during eviction because the memory needs > to be available immediately. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/ttm/ttm_bo.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > di

Re: [PATCH] drm/ttm: fix pipelined gutting for evictions

2020-07-23 Thread Felix Kuehling
Am 2020-07-23 um 5:00 a.m. schrieb Christian König: > We can't pipeline that during eviction because the memory needs > to be available immediately. > > Signed-off-by: Christian König Looks good to me. Reviewed-by: Felix Kuehling Alex, in this case the synchronous ttm_bo_wait would be trigger

[PATCH] drm/ttm: fix pipelined gutting for evictions

2020-07-23 Thread Christian König
We can't pipeline that during eviction because the memory needs to be available immediately. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo